From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault() Date: Wed, 21 Nov 2018 05:05:31 -0800 Message-ID: References: <20181121021309.6595-1-xiyou.wangcong@gmail.com> <20181121021309.6595-2-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Herbert Xu , Eric Dumazet , David Miller To: Cong Wang , netdev@vger.kernel.org Return-path: Received: from mail-pl1-f176.google.com ([209.85.214.176]:44267 "EHLO mail-pl1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728262AbeKUXjv (ORCPT ); Wed, 21 Nov 2018 18:39:51 -0500 Received: by mail-pl1-f176.google.com with SMTP id s5-v6so5478571plq.11 for ; Wed, 21 Nov 2018 05:05:33 -0800 (PST) In-Reply-To: <20181121021309.6595-2-xiyou.wangcong@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/20/2018 06:13 PM, Cong Wang wrote: > Currently, we only dump a few selected skb fields in > netdev_rx_csum_fault(). It is not suffient for debugging checksum > fault. This patch introduces skb_dump() which dumps skb mac header, > network header and its whole skb->data too. > > Cc: Herbert Xu > Cc: Eric Dumazet > Cc: David Miller > Signed-off-by: Cong Wang > --- > + print_hex_dump(level, "skb data: ", DUMP_PREFIX_OFFSET, 16, 1, > + skb->data, skb->len, false); As I mentioned to David, we want all the bytes that were maybe already pulled (skb->head starting point, not skb->data) Also we will miss the trimmed bytes if there were padding data. And it seems the various bugs we have are all tied to the pulled or trimmed bytes. Thanks.