Netdev List
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Yonghong Song <yhs@fb.com>, ast@fb.com, netdev@vger.kernel.org
Cc: kernel-team@fb.com
Subject: Re: [PATCH bpf-next] samples/bpf: fix a compilation failure
Date: Tue, 18 Sep 2018 17:51:40 +0200	[thread overview]
Message-ID: <a218d676-efdd-26ed-a2ca-d15dfb80d3b2@iogearbox.net> (raw)
In-Reply-To: <20180918050813.2138154-1-yhs@fb.com>

On 09/18/2018 07:08 AM, Yonghong Song wrote:
> samples/bpf build failed with the following errors:
> 
>   $ make samples/bpf/
>   ...
>   HOSTCC  samples/bpf/sockex3_user.o
>   /data/users/yhs/work/net-next/samples/bpf/sockex3_user.c:16:8: error: redefinition of ‘struct bpf_flow_keys’
>    struct bpf_flow_keys {
>           ^
>   In file included from /data/users/yhs/work/net-next/samples/bpf/sockex3_user.c:4:0:
>   ./usr/include/linux/bpf.h:2338:9: note: originally defined here
>     struct bpf_flow_keys *flow_keys;
>            ^
>   make[3]: *** [samples/bpf/sockex3_user.o] Error 1
> 
> Commit d58e468b1112d ("flow_dissector: implements flow dissector BPF hook")
> introduced struct bpf_flow_keys in include/uapi/linux/bpf.h and hence
> caused the naming conflict with samples/bpf/sockex3_user.c.
> 
> The fix is to rename struct bpf_flow_keys in samples/bpf/sockex3_user.c
> to flow_keys to avoid the conflict.
> 
> Signed-off-by: Yonghong Song <yhs@fb.com>

Applied to bpf-next, thanks!

      reply	other threads:[~2018-09-18 21:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18  5:08 [PATCH bpf-next] samples/bpf: fix a compilation failure Yonghong Song
2018-09-18 15:51 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a218d676-efdd-26ed-a2ca-d15dfb80d3b2@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@fb.com \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox