From: Dragos Tatulea <dtatulea@nvidia.com>
To: "aleksander.lobakin@intel.com" <aleksander.lobakin@intel.com>,
"saeed@kernel.org" <saeed@kernel.org>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Tariq Toukan <tariqt@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Leon Romanovsky <leonro@nvidia.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [net-next 09/15] net/mlx5e: RX, Log error when page_pool size is too large
Date: Wed, 7 Jun 2023 16:40:08 +0000 [thread overview]
Message-ID: <a2211eeaa8f25d9b2d1d2495e2e2d9de2f81178f.camel@nvidia.com> (raw)
In-Reply-To: <e7b3ebac-21ab-ad3b-7906-6eb4b81ec985@intel.com>
On Wed, 2023-06-07 at 18:24 +0200, Alexander Lobakin wrote:
> From: Saeed Mahameed <saeed@kernel.org>
> Date: Tue, 6 Jun 2023 00:12:13 -0700
>
> > From: Dragos Tatulea <dtatulea@nvidia.com>
> >
> > The page_pool error message is a bit cryptic when the
> > requested size is too large. Add a message on the driver
> > side to display how many pages were actually requested.
>
> Why not rather expand Page Pool's "gave up with error" into detailed
> error messages? I thought we usually go the other way around in the
> upstream and make stuff as generic as possible :D
> With this patch, you'll have 2 error messages at the same time: Page
> Pool's one and then yours.
>
That makes sense. Then you can also print out the values: requested vs the
constant max which is not (yet) exposed. I can prepare a new version of the
patch.
> >
> > Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
> > Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
> [...]
>
> Thanks,
> Olek
Thanks,
Dragos
next prev parent reply other threads:[~2023-06-07 16:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 7:12 [pull request][net-next 00/15] mlx5 updates 2023-06-06 Saeed Mahameed
2023-06-06 7:12 ` [net-next 01/15] RDMA/mlx5: Free second uplink ib port Saeed Mahameed
2023-06-06 7:12 ` [net-next 02/15] {net/RDMA}/mlx5: introduce lag_for_each_peer Saeed Mahameed
2023-06-06 7:12 ` [net-next 03/15] net/mlx5: LAG, check if all eswitches are paired for shared FDB Saeed Mahameed
2023-06-06 7:12 ` [net-next 04/15] net/mlx5: LAG, generalize handling of " Saeed Mahameed
2023-06-06 7:12 ` [net-next 05/15] net/mlx5: LAG, change mlx5_shared_fdb_supported() to static Saeed Mahameed
2023-06-06 7:12 ` [net-next 06/15] net/mlx5: LAG, block multipath LAG in case ldev have more than 2 ports Saeed Mahameed
2023-06-06 7:12 ` [net-next 07/15] net/mlx5: LAG, block multiport eswitch " Saeed Mahameed
2023-06-06 7:12 ` [net-next 08/15] net/mlx5: Enable 4 ports VF LAG Saeed Mahameed
2023-06-06 7:12 ` [net-next 09/15] net/mlx5e: RX, Log error when page_pool size is too large Saeed Mahameed
2023-06-07 16:24 ` Alexander Lobakin
2023-06-07 16:40 ` Dragos Tatulea [this message]
2023-06-06 7:12 ` [net-next 10/15] net/mlx5e: Expose catastrophic steering error counters Saeed Mahameed
2023-06-06 7:12 ` [net-next 11/15] net/mlx5e: Remove RX page cache leftovers Saeed Mahameed
2023-06-06 7:12 ` [net-next 12/15] net/mlx5e: TC, refactor access to hash key Saeed Mahameed
2023-06-06 7:12 ` [net-next 13/15] net/mlx5: Skip inline mode check after mlx5_eswitch_enable_locked() failure Saeed Mahameed
2023-06-07 5:01 ` Jakub Kicinski
2023-06-07 14:10 ` Jason Gunthorpe
2023-06-07 16:19 ` Jakub Kicinski
2023-06-07 23:18 ` Jason Gunthorpe
2023-06-07 15:46 ` Jiri Pirko
2023-06-07 16:22 ` Jakub Kicinski
2023-06-06 7:12 ` [net-next 14/15] mlx5/core: E-Switch, Allocate ECPF vport if it's an eswitch manager Saeed Mahameed
2023-06-06 7:12 ` [net-next 15/15] net/mlx5e: simplify condition after napi budget handling change Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2211eeaa8f25d9b2d1d2495e2e2d9de2f81178f.camel@nvidia.com \
--to=dtatulea@nvidia.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).