From: Shannon Nelson <shannon.nelson@oracle.com>
To: David Miller <davem@davemloft.net>, eric.dumazet@gmail.com
Cc: rob.gardner@oracle.com, netdev@vger.kernel.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc
Date: Thu, 12 Jan 2017 13:58:10 -0800 [thread overview]
Message-ID: <a24f1f0e-457b-0316-b545-fe1362bd7dbe@oracle.com> (raw)
In-Reply-To: <20170112.164731.720625943370044951.davem@davemloft.net>
On 1/12/2017 1:47 PM, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, 12 Jan 2017 13:36:30 -0800
>
>> val should be an union, so that proper alignment is enforced by one
>> member.
>
> Sure, annotating the type so that it is aligned correctly makes
> sense.
>
... and we should change the offending pointer assignment as well. I
can use this and respin a v2 if we're happy with this solution.
sln
next prev parent reply other threads:[~2017-01-12 21:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 19:59 [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc Shannon Nelson
2017-01-12 20:13 ` Eric Dumazet
2017-01-12 20:15 ` Rob Gardner
2017-01-12 20:25 ` Eric Dumazet
2017-01-12 20:30 ` Shannon Nelson
2017-01-12 20:41 ` David Miller
2017-01-12 20:56 ` Shannon Nelson
2017-01-12 21:18 ` David Miller
2017-01-12 21:36 ` Eric Dumazet
2017-01-12 21:47 ` David Miller
2017-01-12 21:58 ` Shannon Nelson [this message]
2017-01-12 21:58 ` David Miller
2017-01-12 20:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a24f1f0e-457b-0316-b545-fe1362bd7dbe@oracle.com \
--to=shannon.nelson@oracle.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.gardner@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).