From: Andrew Lunn <andrew@lunn.ch>
To: Johan Alvarado <contact@c127.dev>
Cc: me@ziyao.cc, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, ggo@tuxedocomputers.com,
andrew+netdev@lunn.ch, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: stmmac: dwmac-motorcomm: fix eFUSE MAC address read failure
Date: Mon, 6 Apr 2026 15:41:36 +0200 [thread overview]
Message-ID: <a276bd90-4883-42e9-b470-5ec0fc762d08@lunn.ch> (raw)
In-Reply-To: <fc5992a4-9532-49c3-8ec1-c2f8c5b84ca1@smtp-relay.sendinblue.com>
> motorcomm_reset(priv);
>
> + /*
> + * After system reset, the eFuse controller needs time to load
> + * its internal data. Without this delay, eFuse reads return
> + * all zeros, causing MAC address detection to fail.
> + */
> + usleep_range(2000, 5000);
> +
This seems reasonable. My only comment is maybe this should be inside
motorcomm_reset(). But i don't have a strong opinion.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2026-04-06 13:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 9:34 [PATCH RESEND net-next v6 0/3] Add DWMAC glue driver for Motorcomm YT6801 Yao Zi
2026-01-09 9:34 ` [PATCH RESEND net-next v6 1/3] net: phy: motorcomm: Support YT8531S PHY in YT6801 Ethernet controller Yao Zi
2026-01-09 10:06 ` Russell King (Oracle)
2026-01-09 9:34 ` [PATCH RESEND net-next v6 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller Yao Zi
2026-01-12 6:10 ` Sai Krishna Gajula
2026-01-12 7:51 ` Yao Zi
2026-01-12 10:17 ` Russell King (Oracle)
2026-01-09 9:34 ` [PATCH RESEND net-next v6 3/3] MAINTAINERS: Assign myself as maintainer of Motorcomm DWMAC glue driver Yao Zi
2026-01-13 3:30 ` [PATCH RESEND net-next v6 0/3] Add DWMAC glue driver for Motorcomm YT6801 patchwork-bot+netdevbpf
2026-01-19 15:33 ` Georg Gottleuber
2026-01-19 15:43 ` Russell King (Oracle)
2026-01-19 17:45 ` Georg Gottleuber
2026-01-19 17:57 ` Georg Gottleuber
2026-01-20 2:45 ` Yao Zi
2026-01-20 9:42 ` Georg Gottleuber
2026-01-20 11:52 ` Yao Zi
2026-01-21 7:10 ` Xi Ruoyao
2026-04-06 7:44 ` [PATCH net] net: stmmac: dwmac-motorcomm: fix eFUSE MAC address read failure Johan Alvarado
2026-04-06 13:41 ` Andrew Lunn [this message]
[not found] ` <4aaa214c-4286-4c24-ab5c-b17a3a1a8f1e@smtp-relay.sendinblue.com>
2026-04-06 12:42 ` Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a276bd90-4883-42e9-b470-5ec0fc762d08@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=contact@c127.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ggo@tuxedocomputers.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@ziyao.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox