From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C1732EAB61; Mon, 6 Apr 2026 13:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775482913; cv=none; b=Tmbf/3RJsIsNMGjY3gG9p0/KKaRt3PAj5DMYcbrSBQSLwU3sg240XWNQKlWiGo5CiiP74yJROwAfzCU7sPbmomAn3B5Ky0VIWIxQSNnO4FFuTt2WPZqEjWeKKYc8XpenTdLpCWGig5cGVNEFQvnic9FSYQCXRpN/+frwzlZy0kI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775482913; c=relaxed/simple; bh=ZkWh6ni8clb78ksTKZC/zmZzMqZGtQd3d5gS8a9Nu7w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H8XJjnylwCG20rxOOdnypejCfbKWAaihtGWRwWBM7F+sPYxjAgVp+6UGb2mJbk7BB2LL3Xy2GkgBM81Ef6jl794gaz7oFgOo7BmzrVzl1P+GAEExQWA52iZN7M6mX4lAodbN2/iLThWp747aSt6ivgKJHJ+Sk65uQ+ioa9qqg2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=NFftRxmS; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="NFftRxmS" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ULEfWSjnqZuwvt7ftQT2cZMGqxDo3cs9w58PjSSKSms=; b=NFftRxmSEWDdcDcVYXH3jB2Cgi 5WYkKX1EkS5m/0XvRfje5kJmtQWASWn2jUr9tIlrMUgUz24X6XiqMnvy/prPdy6XWmb9Kpj/bjo4+ kuBQ7+Gk1PePsp1Crjns7FYrgA/Og1aUAhTm6ZPuHmsEgGTmFlseWyzKquOQz3hEMmww=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1w9kCu-00EzZN-63; Mon, 06 Apr 2026 15:41:36 +0200 Date: Mon, 6 Apr 2026 15:41:36 +0200 From: Andrew Lunn To: Johan Alvarado Cc: me@ziyao.cc, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, ggo@tuxedocomputers.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: stmmac: dwmac-motorcomm: fix eFUSE MAC address read failure Message-ID: References: <24cfefff-1233-4745-8c47-812b502d5d19@tuxedocomputers.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > motorcomm_reset(priv); > > + /* > + * After system reset, the eFuse controller needs time to load > + * its internal data. Without this delay, eFuse reads return > + * all zeros, causing MAC address detection to fail. > + */ > + usleep_range(2000, 5000); > + This seems reasonable. My only comment is maybe this should be inside motorcomm_reset(). But i don't have a strong opinion. Reviewed-by: Andrew Lunn Andrew