From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Sunil Goutham <sgoutham@marvell.com>,
Robert Richter <rrichter@marvell.com>
Subject: Re: [PATCH net-next 6/7] net: phy: cavium: Improve __iomem mess
Date: Sun, 5 Jul 2020 13:46:37 -0700 [thread overview]
Message-ID: <a277a07b-9dd0-c211-e02e-a3be850f9325@gmail.com> (raw)
In-Reply-To: <20200705182921.887441-7-andrew@lunn.ch>
On 7/5/2020 11:29 AM, Andrew Lunn wrote:
> The MIPS low level register access functions seem to be missing
> __iomem annotation. This cases lots of sparse warnings, when code
s/cases/causes/g
> casts off the __iomem. Make the Cavium MDIO drivers cleaner by pushing
> the casts lower down into the helpers, allow the drivers to work as
> normal, with __iomem.
>
> bus->register_base is now an void *, rather than a u64. So forming the
> mii_bus->id string cannot use %llx any more. Use %px, so this kernel
> address is still exposed to user space, as it was before.
>
> Cc: Sunil Goutham <sgoutham@marvell.com>
> Cc: Robert Richter <rrichter@marvell.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-07-05 20:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 18:29 [PATCH net-next 0/7] drivers/net/phy C=1 W=1 fixes Andrew Lunn
2020-07-05 18:29 ` [PATCH net-next 1/7] net: phy: at803x: Avoid comparison is always false warning Andrew Lunn
2020-07-06 18:06 ` Jakub Kicinski
2020-07-05 18:29 ` [PATCH net-next 2/7] net: phy: Fixup parameters in kerneldoc Andrew Lunn
2020-07-05 20:44 ` Florian Fainelli
2020-07-05 18:29 ` [PATCH net-next 3/7] net: phy: Properly define genphy_c45_driver Andrew Lunn
2020-07-05 20:45 ` Florian Fainelli
2020-07-05 18:29 ` [PATCH net-next 4/7] net: phy: Make phy_10gbit_fec_features_array static Andrew Lunn
2020-07-05 20:45 ` Florian Fainelli
2020-07-05 18:29 ` [PATCH net-next 5/7] net: phy: dp83640: Fixup cast to restricted __be16 warning Andrew Lunn
2020-07-05 20:45 ` Florian Fainelli
2020-07-06 6:37 ` Richard Cochran
2020-07-05 18:29 ` [PATCH net-next 6/7] net: phy: cavium: Improve __iomem mess Andrew Lunn
2020-07-05 20:46 ` Florian Fainelli [this message]
2020-07-05 18:29 ` [PATCH net-next 7/7] net: phy: mdio-octeon: Cleanup module loading dependencies Andrew Lunn
2020-07-05 20:50 ` Florian Fainelli
2020-07-06 10:38 ` Greg Kroah-Hartman
2020-07-07 0:30 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a277a07b-9dd0-c211-e02e-a3be850f9325@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rrichter@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).