From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: RE: [PATCH] net: xenbus: remove redundant condition check before debugfs_remove_recursive Date: Tue, 11 Sep 2018 08:01:50 +0000 Message-ID: References: <1536413706-31838-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "xen-devel@lists.xenproject.org" , "netdev@vger.kernel.org" To: 'zhong jiang' , "davem@davemloft.net" , Wei Liu Return-path: Received: from smtp.eu.citrix.com ([185.25.65.24]:56146 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726484AbeIKM77 (ORCPT ); Tue, 11 Sep 2018 08:59:59 -0400 In-Reply-To: <1536413706-31838-1-git-send-email-zhongjiang@huawei.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: > -----Original Message----- > From: zhong jiang [mailto:zhongjiang@huawei.com] > Sent: 08 September 2018 14:35 > To: davem@davemloft.net; Paul Durrant ; Wei Liu > > Cc: xen-devel@lists.xenproject.org; netdev@vger.kernel.org > Subject: [PATCH] net: xenbus: remove redundant condition check before > debugfs_remove_recursive > > debugfs_remove_recursive has taken the IS_ERR_OR_NULL into account. > Just > remove the unnecessary condition check. > > Signed-off-by: zhong jiang Reviewed-by: Paul Durrant > --- > drivers/net/xen-netback/xenbus.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen- > netback/xenbus.c > index cd51492..fe1d522 100644 > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -254,8 +254,7 @@ static void xenvif_debugfs_delif(struct xenvif *vif) > if (IS_ERR_OR_NULL(xen_netback_dbg_root)) > return; > > - if (!IS_ERR_OR_NULL(vif->xenvif_dbg_root)) > - debugfs_remove_recursive(vif->xenvif_dbg_root); > + debugfs_remove_recursive(vif->xenvif_dbg_root); > vif->xenvif_dbg_root = NULL; > } > #endif /* CONFIG_DEBUG_FS */ > -- > 1.7.12.4