From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FB6C77B73 for ; Thu, 27 Apr 2023 09:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243269AbjD0Joa (ORCPT ); Thu, 27 Apr 2023 05:44:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243285AbjD0Jo2 (ORCPT ); Thu, 27 Apr 2023 05:44:28 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CEB94699; Thu, 27 Apr 2023 02:44:24 -0700 (PDT) Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33R9b2ik022872; Thu, 27 Apr 2023 09:44:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=NsdeLVPvnuTdBPZv3WD2Vnht6opWJ6idi7ZjkBpR5pc=; b=gcDzmsTyhsMsJDiXanvDKgoVy9G0lgLNG7KINI8NT7oxXPSVZr8Oft4A/Hp9Xf3QHgSN GBcroRKehrnvcqdlaMSw82ngxc0dlbCsHkd0XRvTOaXubB5xuPCZZlfffcB5zJK+aIkp s9BzamajLkQHo61gh8r8fRjXO0rw95miaoIIpMSYbp13m72KLGnb1yf16bYL6BOMsnCj bVh+1uUTIpEpbjEWmLzZl8LtT64tjLxUzWCAJswLzztJ3R/v4NZiJsKsDinD+8Yehy0b L9yH/hWTsXj2VqmfgBJg42usbuemFLJBnz86Dfh7ySq8WLST3uPnZ8Pc6UvTRfsw8bb1 mQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q7mp5c60b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Apr 2023 09:44:19 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33R9bs3q029470; Thu, 27 Apr 2023 09:44:19 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q7mp5c5xa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Apr 2023 09:44:19 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33R36j8n004299; Thu, 27 Apr 2023 09:44:15 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3q46ug2uyw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Apr 2023 09:44:15 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33R9iC0V2032128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Apr 2023 09:44:12 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 14D3B2004E; Thu, 27 Apr 2023 09:44:12 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33CEA20043; Thu, 27 Apr 2023 09:44:11 +0000 (GMT) Received: from [9.179.20.145] (unknown [9.179.20.145]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 27 Apr 2023 09:44:11 +0000 (GMT) Message-ID: Date: Thu, 27 Apr 2023 11:44:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC net] net/mlx5: Fix performance regression for request-response workloads Content-Language: en-US From: Alexandra Winter To: Saeed Mahameed Cc: David Miller , Jakub Kicinski , Niklas Schnelle , netdev , linux-s390@vger.kernel.org, Heiko Carstens , Christian Borntraeger , Eric Dumazet , Halil Pasic References: <20220907122505.26953-1-wintera@linux.ibm.com> <375efe42-910d-69ae-e48d-cff0298dd104@linux.ibm.com> <886c690b-cc35-39a0-8397-834e70fb329b@linux.ibm.com> <20220930233708.kfxhgn2ytmraqhg7@sfedora> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UN6T5kneicLLAwWwZr0DF8NLmh2Z-nvh X-Proofpoint-ORIG-GUID: hIZ1xaRUbVAtVg14Pq3BZwpwA3bWrR-3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-27_07,2023-04-26_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1011 spamscore=0 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304270082 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 29.12.22 09:27, Alexandra Winter wrote: > > > On 01.10.22 01:37, Saeed Mahameed wrote: >> On 26 Sep 12:06, Alexandra Winter wrote: >> >> [ ... ] >>> >>> Saeed, >>> As discussed at LPC, could you please consider adding a workaround to the >>> Mellanox driver, to use non-SG SKBs for small messages? As mentioned above >>> we are seeing 13% throughput degradation, if 2 pages need to be mapped >>> instead of 1. >>> >>> While Eric's ideas sound very promising, just using non-SG in these cases >>> should be enough to mitigate the performance regression we see. >> >> Hi Alexandra, sorry for the late response. >> >> Yeas linearizing small messages makes sense, but will require some careful >> perf testing. >> >> We will do our best to include this in the next kernel release cycle. >> I will take it with the mlx5e team next week, everybody is on vacation this >> time of year :). >> >> Thanks, >> Saeed. > > Hello Saeed, > may I ask whether you had a chance to include such a patch in the 6.2 kernel? > Or is this still on your ToDo list? > I haven't seen anything like this on the mailing list, but I may have overlooked it. > All the best for 2023 > Alexandra Hello Saeed, any news about linearizing small messages? Is there any way we could be of help? Kind regards Alexandra