From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86ABAC43381 for ; Wed, 20 Feb 2019 07:54:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEA2B21773 for ; Wed, 20 Feb 2019 07:54:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="Pv8tW9zi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726201AbfBTHyL (ORCPT ); Wed, 20 Feb 2019 02:54:11 -0500 Received: from smtpcmd04131.aruba.it ([62.149.158.131]:59559 "EHLO smtpcmd04131.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfBTHyL (ORCPT ); Wed, 20 Feb 2019 02:54:11 -0500 Received: from [192.168.1.39] ([93.146.66.165]) by smtpcmd04.ad.aruba.it with bizsmtp id evu11z00c3Zw7e501vu180; Wed, 20 Feb 2019 08:54:08 +0100 Subject: Re: Possible bug into DSA2 code. To: Andrew Lunn Cc: Florian Fainelli , Vivien Didelot , "David S. Miller" , netdev@vger.kernel.org References: <528f797d-445b-a314-d8ef-db15a3b6a8ce@enneenne.com> <20190209193409.GI30856@lunn.ch> <084b3973-88b9-8c71-50d5-9d773999ad04@enneenne.com> <49728829-49cc-6d6a-04b1-ccfc1e5266dd@enneenne.com> <2651a882-c5ab-ba3b-ef4c-731dca90147d@gmail.com> <24527f56-41dd-f257-0f5e-c568cb80881e@gmail.com> <20190219000340.GJ14879@lunn.ch> From: Rodolfo Giometti Message-ID: Date: Wed, 20 Feb 2019 08:54:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190219000340.GJ14879@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aruba.it; s=a1; t=1550649248; bh=vAXRMlhT1VKEHURqZ5NmdSKumZVyH3MZKsOZdfm5bfs=; h=Subject:To:From:Date:MIME-Version:Content-Type; b=Pv8tW9zigmGDC3g7oovV4yPjSnwC5HPv+FGNGAjUGxL9H6tjeeXvEMq65TJ9SRUh4 FxjL1azc8xpecmOylmzB1gCeUlEqjy/5A3lXviUq0LvK5pxS/XG7GOP9U4Js+C3OSl Fu0Co0TX/G+X7mBRbcMf8d9Ret0erWevKtFYNwbjYEf6YkL7a10PI9OhKzNGtc01p6 UugSAR4pF6MW2fsYXXdjsyHzcBSKrhkm2miIo9ah2bP2Y1BMkQz44mEoBTV38TfPEO aXgY9qmJviNURSBjBUCGGDwuHQuNxtDV3iLiqS7XQXKT7klPk8atMGaavDeglx+98u Vdk85JpWk91WA== Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 19/02/2019 01:03, Andrew Lunn wrote: >> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c >> index 54a5b660640a..bb46ebbb2bb8 100644 >> --- a/drivers/net/dsa/mv88e6xxx/chip.c >> +++ b/drivers/net/dsa/mv88e6xxx/chip.c >> @@ -2399,7 +2399,7 @@ static int mv88e6xxx_setup(struct dsa_switch *ds) >> int i; >> >> chip->ds = ds; >> - ds->slave_mii_bus = mv88e6xxx_default_mdio_bus(chip); >> + ds->slave_mii_bus = NULL; >> >> mutex_lock(&chip->reg_lock); >> >> Is that right? > > Hi Rodolfo > > Humm, that needs testing. There are two used combinations you need to > test: > > No MDIO node in device tree, e.g. > arch/arm/boot/dts/kirkwood-dir665.dts > > MDIO node in device tree, e.g: > arch/arm/boot/dts/vf610-zii-dev-rev-b.dts I'm sorry but I haven't such boards... :'( > There is a third combination which will appear soon. There is only the > external mdio bus in device tree: > > port@9 { > reg = <9>; > label = "eth_cu_1000_2"; > phy-handle = <&phy9>; > phy-mode = "sgmii"; > managed = "in-band-status"; > }; > }; > > mdio1 { > compatible = "marvell,mv88e6xxx-mdio-external"; > #address-cells = <1>; > #size-cells = <0>; > > phy9: phy9@0 { > compatible = "ethernet-phy-ieee802.3-c45"; > pinctrl-0 = <&pinctrl_gpio_phy9>; > pinctrl-names = "default"; > interrupt-parent = <&gpio2>; > interrupts = <30 IRQ_TYPE_LEVEL_LOW>; > reg = <0>; > }; > }; > > Here port 9 uses the external MDIO bus and all the other ports > implicitly make use of the internal MDIO bus. Mmm... maybe should code into drivers/net/dsa/mv88e6xxx use private data to hold used mdio busses instead of ds->slave_mii_bus pointer? Ciao, Rodolfo -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti