Netdev List
 help / color / mirror / Atom feed
From: "Alice Mikityanska" <alice.kernel@fastmail.im>
To: "Haishuang Yan" <yanhaishuang@cmss.chinamobile.com>,
	netdev@vger.kernel.org
Cc: "Matthieu Baerts" <matttbe@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] selftests: net: big_tcp_tunnels: Fix the IPv6 route change
Date: Fri, 09 Oct 2026 13:59:43 +0300	[thread overview]
Message-ID: <a300a06d-89d0-4977-95aa-a0b3d375a8b4@app.fastmail.com> (raw)
In-Reply-To: <20261007014731.1277055-1-yanhaishuang@cmss.chinamobile.com>

On Wed, Oct 7, 2026, at 04:47, Haishuang Yan wrote:
> On slow machines, do_test() raises initcwnd on the route into the tunnel
> with "ip route change". For IPv6 traffic this fails with:
>
>   RTNETLINK answers: No such file or directory

Thanks for the fix! It's already merged, but anyway:

Tested-by: Alice Mikityanska <alice.kernel@fastmail.im>

> The IPv6 prefix route of the tunnel address has metric 256, while
> "ip -6 route change" without a metric looks for a route with the default
> metric 1024, so nothing is changed. The test still passes, but without
> the larger initcwnd it is meant to use.
>
> Pass the metric of the prefix route.
>
> Fixes: 1d62b83fb751 ("selftests: net: Fix slow configurations in 
> big_tcp_tunnels.sh")
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> ---
>  tools/testing/selftests/net/big_tcp_tunnels.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/big_tcp_tunnels.sh 
> b/tools/testing/selftests/net/big_tcp_tunnels.sh
> index cc0875e52fb9..fb43fed824e3 100755
> --- a/tools/testing/selftests/net/big_tcp_tunnels.sh
> +++ b/tools/testing/selftests/net/big_tcp_tunnels.sh
> @@ -145,7 +145,8 @@ do_test() {
>  			    route change 192.168.2.0/24 dev tun0 initcwnd 100
>  		else
>  			ip -netns "$CLIENT_NS" -6 \
> -			    route change 2001:db8::2:0/112 dev tun0 initcwnd 100
> +			    route change 2001:db8::2:0/112 dev tun0 initcwnd 100 \
> +			    metric 256
>  		fi
>  	else
>  		ip netns exec "$CLIENT_NS" \
> -- 
> 2.43.0

      parent reply	other threads:[~2026-10-09 11:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07  1:47 [PATCH net] selftests: net: big_tcp_tunnels: Fix the IPv6 route change Haishuang Yan
2026-10-08  4:43 ` Narcisa Vasile
2026-10-08 18:10 ` patchwork-bot+netdevbpf
2026-10-09 10:59 ` Alice Mikityanska [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a300a06d-89d0-4977-95aa-a0b3d375a8b4@app.fastmail.com \
    --to=alice.kernel@fastmail.im \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=yanhaishuang@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox