From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Ian King Subject: Re: [PATCH 1/2] samples: bpf: ensure that we don't load over MAX_PROGS programs Date: Fri, 13 Jul 2018 16:13:30 +0100 Message-ID: References: <20180713151139.aiqginrahbimfsop@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Daniel Borkmann , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter , Alexei Starovoitov Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:37426 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729647AbeGMP2g (ORCPT ); Fri, 13 Jul 2018 11:28:36 -0400 In-Reply-To: <20180713151139.aiqginrahbimfsop@kili.mountain> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 13/07/18 16:11, Dan Carpenter wrote: > I can't see that we check prog_cnt to ensure it doesn't go over > MAX_PROGS. > > Signed-off-by: Dan Carpenter > > diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c > index 89161c9ed466..904e775d1a44 100644 > --- a/samples/bpf/bpf_load.c > +++ b/samples/bpf/bpf_load.c > @@ -107,6 +107,9 @@ static int load_and_attach(const char *event, struct bpf_insn *prog, int size) > return -1; > } > > + if (prog_cnt == MAX_PROGS) > + return -1; > + Should that be "if (prog_cnt >= MAX_PROGS)" ? > fd = bpf_load_program(prog_type, prog, insns_cnt, license, kern_version, > bpf_log_buf, BPF_LOG_BUF_SIZE); > if (fd < 0) { > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >