From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BA683E6DC6; Thu, 25 Jun 2026 16:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782403461; cv=none; b=khbrr7HBKhtQCZQbE4C6hB/TQ4BKZEsBGPT6XW1Jo3JK0rAO/H0V+OEjAmWBcNjCtEkWTbk5c35QcD0EW81OwxGqEnRwZB6FRZb10Na+kYB/9q5Qac1INXvO77K7lP5sBK5LdKEVKGd9gCU2jKSdquym5wdbBWYjWt8LEvOF0w4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782403461; c=relaxed/simple; bh=XW3SzIEXudbXYq7PqSSb1LBoVhsyZbg4Bfj+ybVG9kQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AnLpG6kqdj4yP+0IGgrUIuGcqSC046u/lQE1Fx3NPjogqN3Z21B6Cju0CnuHiitOxeLB/5GIKDNTFzNtFo7L+Nf+dLuKg0KuDdkpyDY78n84FEZYuXjkYn5kj/8qfVqwd4glxNeovIYq99FN+A7nV5tzDkalSSfF/8z8vVrJtJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=O1CuqApn; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="O1CuqApn" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id D1FEFC5CD54; Thu, 25 Jun 2026 16:04:18 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 37CA960220; Thu, 25 Jun 2026 16:04:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BC886104C974F; Thu, 25 Jun 2026 18:03:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782403448; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=rj4K5nBqdL50bEj1X13u+dnWAqWMlIUbG7uN0Y70STY=; b=O1CuqApnXCMMrvrHYXL1wRPyPgifoZSIg3AMIdGY6ee1lLC2yxnQkrTUu27eWupa3VdrSj 0VxUp6cPCDNusNd8CuUnj9wtYOeMvDlWFNzvua+93+jmHoiYW8dAjKzuVBa/o6d/ANaUwj wShZhnK5YAMzURy66mXbBXIuI8MwtuJMK4JjMfLgXx84uSgWJRVQn5+FRkSohcjM1ah18d Mxs3uzffS3xzDti6moRmT8W37djHQ5roZ8A8HsuME+/z33Nmsj2c68u8mgY1kSzlghn/2a Wr1tqntjb7ZbEcvvw6mxKY/C9Vzh8ixGBtHQNHbMLbxr5YBps4bm1QvIs2LIVQ== Message-ID: Date: Thu, 25 Jun 2026 18:03:57 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] Documentation: networking: Add a test plan for ethtool pause validation To: Andrew Lunn Cc: Jakub Kicinski , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Simon Horman , Russell King , Heiner Kallweit , Jonathan Corbet , Shuah Khan , Oleksij Rempel , Vladimir Oltean , Florian Fainelli , thomas.petazzoni@bootlin.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20260522175109.198059-1-maxime.chevallier@bootlin.com> <2293244a-c6a9-4642-a721-dada8a081dbc@lunn.ch> <7a88fee8-bbb3-480f-9c93-677b7270a940@bootlin.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 > > Does it even make sense to advertise this when in HD? But i don't > think we need to consider this now. I consider HD low priority, i > doubt it is actually used very often. We should concentrate on FD > testing. That's fine by me as well, let's keep it simple, we may revisit that if we really need to. > >> # ethtool -a eth2 >> Autonegotiate: on >> RX: off >> TX: off >> RX negotiated: on >> TX negotiated: on >> >> >> Sure, pause and HD don't make sense, however what I find confusing to some >> extent is that the only place we have information about the *actual* pause >> settings is the "link is Up" log in dmesg. > > Maybe we should extend ksetting get to return the resolved pause > parameters? But i'm not sure how much that actually gives us. Anything > using phylink will just ask phylink to fill in the ksettings > information, and it seems unlikely phylink gets it wrong. What we are > really trying to test is drivers which don't user phylink, those are > the ones which are generally broken, and they are not going to > implement anything new in ksettings. Correct yes. If the MAC driver uses phylink and a test fails, it very likely means that the PHY driver is doing shady stuff (and some are/were for pause) > So i think the test has to look > at: > >> Advertised pause frame use: Symmetric Receive-only >> Link partner advertised pause frame use: Symmetric Receive-only > > and check these match what we expect. All good for me :) thanks for you feedback, Maxime