From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E375A17F7 for ; Wed, 16 Aug 2023 07:55:50 +0000 (UTC) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 114A61A8; Wed, 16 Aug 2023 00:55:49 -0700 (PDT) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RQgMf4VrnzNmm2; Wed, 16 Aug 2023 15:52:14 +0800 (CST) Received: from [10.174.178.66] (10.174.178.66) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 16 Aug 2023 15:55:45 +0800 Message-ID: Date: Wed, 16 Aug 2023 15:55:30 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH net-next] selftests: bonding: remove redundant delete action of device link1_1 To: Hangbin Liu CC: , , , , , , References: <20230812084036.1834188-1-shaozhengchao@huawei.com> From: shaozhengchao In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.66] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500026.china.huawei.com (7.185.36.106) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 2023/8/16 14:11, Hangbin Liu wrote: > On Sat, Aug 12, 2023 at 04:40:36PM +0800, Zhengchao Shao wrote: >> When run command "ip netns delete client", device link1_1 has been >> deleted. So, it is no need to delete link1_1 again. Remove it. > Hi Hangbin: > What if the test exit because the cmd execute failed before setting > link1_1 to netns client? > > Thanks > Hangbin >> Your consideration is indeed possible. "ip link del link1_1 >/dev/null 2>&1" maybe looks better? Zhengchao Shao >> Signed-off-by: Zhengchao Shao >> --- >> .../drivers/net/bonding/bond-arp-interval-causes-panic.sh | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh >> index 71c00bfafbc9..7b2d421f09cf 100755 >> --- a/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh >> +++ b/tools/testing/selftests/drivers/net/bonding/bond-arp-interval-causes-panic.sh >> @@ -11,7 +11,6 @@ finish() >> { >> ip netns delete server || true >> ip netns delete client || true >> - ip link del link1_1 || true >> } >> >> trap finish EXIT >> -- >> 2.34.1 >>