* [PATCH net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc_hd}
@ 2026-02-06 11:18 Simon Horman
2026-02-09 22:29 ` Joe Damato
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Simon Horman @ 2026-02-06 11:18 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Mark Bloch
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-rdma, Simon Horman
These functions were recently removed by commit 24cf78c73831
("net/mlx5e: SHAMPO, Switch to header memcpy"), however,
their declarations were left behind.
This patch removes those declarations.
Flagged by review-prompts while I was exercising Orc mode locally.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
index 843f732e4eedb005eba58b9a9ebe48c6703906e5..a7de3a3efc49f6c237ea42b0b932fbe1f5aca847 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
@@ -1034,8 +1034,6 @@ void mlx5e_build_ptys2ethtool_map(void);
bool mlx5e_check_fragmented_striding_rq_cap(struct mlx5_core_dev *mdev, u8 page_shift,
enum mlx5e_mpwrq_umr_mode umr_mode);
-void mlx5e_shampo_fill_umr(struct mlx5e_rq *rq, int len);
-void mlx5e_shampo_dealloc_hd(struct mlx5e_rq *rq);
void mlx5e_get_stats(struct net_device *dev, struct rtnl_link_stats64 *stats);
void mlx5e_fold_sw_stats64(struct mlx5e_priv *priv, struct rtnl_link_stats64 *s);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc_hd}
2026-02-06 11:18 [PATCH net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc_hd} Simon Horman
@ 2026-02-09 22:29 ` Joe Damato
2026-02-10 6:09 ` Tariq Toukan
2026-02-10 15:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Joe Damato @ 2026-02-09 22:29 UTC (permalink / raw)
To: Simon Horman
Cc: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Mark Bloch,
Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-rdma
On Fri, Feb 06, 2026 at 11:18:51AM +0000, Simon Horman wrote:
> These functions were recently removed by commit 24cf78c73831
> ("net/mlx5e: SHAMPO, Switch to header memcpy"), however,
> their declarations were left behind.
>
> This patch removes those declarations.
>
> Flagged by review-prompts while I was exercising Orc mode locally.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Joe Damato <joe@dama.to>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc_hd}
2026-02-06 11:18 [PATCH net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc_hd} Simon Horman
2026-02-09 22:29 ` Joe Damato
@ 2026-02-10 6:09 ` Tariq Toukan
2026-02-10 15:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Tariq Toukan @ 2026-02-10 6:09 UTC (permalink / raw)
To: Simon Horman, Saeed Mahameed, Leon Romanovsky, Tariq Toukan,
Mark Bloch
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-rdma
On 06/02/2026 13:18, Simon Horman wrote:
> These functions were recently removed by commit 24cf78c73831
> ("net/mlx5e: SHAMPO, Switch to header memcpy"), however,
> their declarations were left behind.
>
> This patch removes those declarations.
>
> Flagged by review-prompts while I was exercising Orc mode locally.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> index 843f732e4eedb005eba58b9a9ebe48c6703906e5..a7de3a3efc49f6c237ea42b0b932fbe1f5aca847 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> @@ -1034,8 +1034,6 @@ void mlx5e_build_ptys2ethtool_map(void);
> bool mlx5e_check_fragmented_striding_rq_cap(struct mlx5_core_dev *mdev, u8 page_shift,
> enum mlx5e_mpwrq_umr_mode umr_mode);
>
> -void mlx5e_shampo_fill_umr(struct mlx5e_rq *rq, int len);
> -void mlx5e_shampo_dealloc_hd(struct mlx5e_rq *rq);
> void mlx5e_get_stats(struct net_device *dev, struct rtnl_link_stats64 *stats);
> void mlx5e_fold_sw_stats64(struct mlx5e_priv *priv, struct rtnl_link_stats64 *s);
>
>
>
>
>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks for your patch.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc_hd}
2026-02-06 11:18 [PATCH net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc_hd} Simon Horman
2026-02-09 22:29 ` Joe Damato
2026-02-10 6:09 ` Tariq Toukan
@ 2026-02-10 15:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-02-10 15:00 UTC (permalink / raw)
To: Simon Horman
Cc: saeedm, leon, tariqt, mbloch, andrew+netdev, davem, edumazet,
kuba, pabeni, netdev, linux-rdma
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 06 Feb 2026 11:18:51 +0000 you wrote:
> These functions were recently removed by commit 24cf78c73831
> ("net/mlx5e: SHAMPO, Switch to header memcpy"), however,
> their declarations were left behind.
>
> This patch removes those declarations.
>
> Flagged by review-prompts while I was exercising Orc mode locally.
> Compile tested only.
>
> [...]
Here is the summary with links:
- [net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc_hd}
https://git.kernel.org/netdev/net-next/c/ad1f18e985cb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-10 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-06 11:18 [PATCH net-next] net/mlx5e: remove declarations of mlx5e_shampo_{fill_umr,dealloc_hd} Simon Horman
2026-02-09 22:29 ` Joe Damato
2026-02-10 6:09 ` Tariq Toukan
2026-02-10 15:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox