From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09161C072AD for ; Mon, 20 May 2019 00:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D73AD2081C for ; Mon, 20 May 2019 00:29:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r2M4jtdb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729719AbfETA3Z (ORCPT ); Sun, 19 May 2019 20:29:25 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41093 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727852AbfETA3Z (ORCPT ); Sun, 19 May 2019 20:29:25 -0400 Received: by mail-pg1-f194.google.com with SMTP id z3so5887535pgp.8; Sun, 19 May 2019 17:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hBaYYOgHBn5Iq/to9VwGy7dRm9N+B3reJ/FtJOoZbpE=; b=r2M4jtdbalke0beP4MXcM1cAhBkOWSLrP9AhggPcnbqfJEuQXFXXs1hVki0nIFrZkr CtaKjKEjNs1O+lf5KZtPkKTUEs90AlqEUheG9+qhTpFSJLJf0F1dyIGH1BtJkWUwsFG0 6UhgtLNq63jsiqpDGLOzUstFBoOjYCtRDNBuIQvkVXsVLRn36IOzCae/fxIqZbiu1iCl 4b2sAgIlLDxxMUpNNxZvizLZmPTozXq5mUenSB7PfpSt4GmVY01Xv3o+ziPEUKRAN0f+ AsYXPt1X61mby+nLPEXKzKT/bMj7i/3ZpEGWFZhCVaJWc2qZXIjKg+wYkgX8sS/x2cKh l2LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hBaYYOgHBn5Iq/to9VwGy7dRm9N+B3reJ/FtJOoZbpE=; b=m/2DLbWYGy2TbwVTPedXyV9KOODGXPN9lLzHNNcM0fPw6JN/afC9GoX0YK4V4lPY8m w/WaI1CROAP1eSUxfeSAfTR9BJMylonsmXBvo0fDTv4neJjvAiy2sWlENmEqt0HaBXYF +ht5kRv0XOAmAYD2VU4g6hacw8q7pM74rgyVn/2j3O83zhzZacWremQuPY4iTQpQa6Ah m4u796YFmjWWVeIGDFxem3LyugPbGNi1Q5kfFk9B2B5xnpMZSSpMq5923htbsEcyuzn7 bS0nprPPexM5P2lWt3KrZZ72EnDnJIFajnfTYAPiE/J3VChQRox99gKkdxkC8Y0qLW80 S/XQ== X-Gm-Message-State: APjAAAU3y7eofmlO+QresrdigSv2M+qeqOc7yCc0+0pb3MvuBrK33UyS BpY8OYVceyf6Z6FYKAoEInR6enoR X-Google-Smtp-Source: APXvYqzXS8Kfg7+hoCIkTxpThWBlABRdcXxloJXFPPWjqikBFnMvV6LpBzSY+vOyezOanyJ+ow9F8g== X-Received: by 2002:a63:9d8d:: with SMTP id i135mr72466722pgd.245.1558312164132; Sun, 19 May 2019 17:29:24 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:319f:d85a:786b:cab7? ([2601:282:800:fd80:319f:d85a:786b:cab7]) by smtp.googlemail.com with ESMTPSA id l65sm25918110pfb.7.2019.05.19.17.29.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 May 2019 17:29:22 -0700 (PDT) Subject: Re: [PATCH 4.9 41/51] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied To: Nathan Chancellor , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Thomas Haller , Hangbin Liu , "David S. Miller" , netdev@vger.kernel.org References: <20190515090616.669619870@linuxfoundation.org> <20190515090628.066392616@linuxfoundation.org> <20190519154348.GA113991@archlinux-epyc> From: David Ahern Message-ID: Date: Sun, 19 May 2019 18:29:19 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190519154348.GA113991@archlinux-epyc> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 5/19/19 9:43 AM, Nathan Chancellor wrote: > Hi all, > > This commit is causing issues on Android devices when Wi-Fi and mobile > data are both enabled. The device will do a soft reboot consistently. > So far, I've had reports on the Pixel 3 XL, OnePlus 6, Pocophone, and > Note 9 and I can reproduce on my OnePlus 6. > > Sorry for taking so long to report this, I just figured out how to > reproduce it today and I didn't want to report it without that. > > Attached is a full dmesg and the relevant snippet from Android's logcat. > > Let me know what I can do to help debug, > Nathan > It's a backport problem. err needs to be reset to 0 before the goto.