From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 net-next 7/8] net: ethernet: xgbe: expand PHY_GBIT_FEAUTRES Date: Sun, 30 Sep 2018 11:41:00 +0300 Message-ID: References: <1538255056-15114-1-git-send-email-andrew@lunn.ch> <1538255056-15114-8-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev , Florian Fainelli , Maxime Chevallier To: Andrew Lunn , David Miller Return-path: Received: from mail-lf1-f66.google.com ([209.85.167.66]:42231 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727755AbeI3PNH (ORCPT ); Sun, 30 Sep 2018 11:13:07 -0400 Received: by mail-lf1-f66.google.com with SMTP id s10-v6so268166lfc.9 for ; Sun, 30 Sep 2018 01:41:01 -0700 (PDT) In-Reply-To: <1538255056-15114-8-git-send-email-andrew@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello! On 9/30/2018 12:04 AM, Andrew Lunn wrote: > The macro PHY_GBIT_FEAUTRES needs to change into a bitmap in order to > support link_modes. Remove its use from xgde by replacing it with its > definition. > > Probably, the current behavior is wrong. It probably should be > ANDing not assigning. ORing, maybe? > Signed-off-by: Andrew Lunn > --- > v2 > Remove unneeded () Really? :-) > --- > drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > index a7e03e3ecc93..151bdb629e8a 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > @@ -878,8 +878,9 @@ static bool xgbe_phy_finisar_phy_quirks(struct xgbe_prv_data *pdata) > phy_write(phy_data->phydev, 0x04, 0x0d01); > phy_write(phy_data->phydev, 0x00, 0x9140); > > - phy_data->phydev->supported = PHY_GBIT_FEATURES; > - phy_data->phydev->advertising = phy_data->phydev->supported; > + phy_data->phydev->supported = PHY_10BT_FEATURES | > + PHY_100BT_FEATURES | > + PHY_1000BT_FEATURES; > phy_support_asym_pause(phy_data->phydev); > > netif_dbg(pdata, drv, pdata->netdev, > @@ -950,8 +951,9 @@ static bool xgbe_phy_belfuse_phy_quirks(struct xgbe_prv_data *pdata) > reg = phy_read(phy_data->phydev, 0x00); > phy_write(phy_data->phydev, 0x00, reg & ~0x00800); > > - phy_data->phydev->supported = PHY_GBIT_FEATURES; > - phy_data->phydev->advertising = phy_data->phydev->supported; > + phy_data->phydev->supported = (PHY_10BT_FEATURES | > + PHY_100BT_FEATURES | > + PHY_1000BT_FEATURES); First time w/o parens and 2nd time with them doesn't look very consistent... > phy_support_asym_pause(phy_data->phydev); > > netif_dbg(pdata, drv, pdata->netdev, MBR, Sergei