From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv
Date: Thu, 31 Aug 2017 14:34:20 -0600 [thread overview]
Message-ID: <a3a3328009e7c0ca8d910e1b15ad0b2a@codeaurora.org> (raw)
In-Reply-To: <20170831140727.28170-1-colin.king@canonical.com>
On 2017-08-31 08:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> priv is being assigned but is never used, so remove it.
>
> Cleans up clang build warning:
> "warning: Value stored to 'priv' is never read"
>
> Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial
> implementation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> index c8b573d28dcf..bf7455fdafcc 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> @@ -73,9 +73,6 @@ static const struct net_device_ops rmnet_vnd_ops = {
> */
> void rmnet_vnd_setup(struct net_device *rmnet_dev)
> {
> - struct rmnet_priv *priv;
> -
> - priv = netdev_priv(rmnet_dev);
> netdev_dbg(rmnet_dev, "Setting up device %s\n", rmnet_dev->name);
>
> rmnet_dev->netdev_ops = &rmnet_vnd_ops;
Thanks for fixing this.
Acked-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
next prev parent reply other threads:[~2017-08-31 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 14:07 [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv Colin King
2017-08-31 20:34 ` Subash Abhinov Kasiviswanathan [this message]
2017-09-02 1:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3a3328009e7c0ca8d910e1b15ad0b2a@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).