From: David Ahern <dsahern@gmail.com>
To: Ben Greear <greearb@candelatech.com>, netdev <netdev@vger.kernel.org>
Subject: Re: vrf and multicast problem
Date: Fri, 11 Mar 2022 17:36:33 -0700 [thread overview]
Message-ID: <a3ab5052-51ac-81d6-c65e-cfcfede3297a@gmail.com> (raw)
In-Reply-To: <43de8172-0cd4-bf6f-b89b-864fd7bf4dee@candelatech.com>
On 3/10/22 6:41 PM, Ben Greear wrote:
>>> can you reproduce this using namespaces and veth pairs? if so, send me
>>> the script and I will take a look.
>>
>> I think debugging it will be easier than writing something for you to
>> reproduce it...
A test case needs to be added to
tools/testing/selftests/net/fcnal-test.sh; nettest.c provides the
networking APIs so it should be fairly trivial to add.
>
> After some more investigation of this code, I am questioning the need
> for this logic:
>
> /* update flow if oif or iif point to device enslaved to l3mdev */
> l3mdev_update_flow(net, flowi4_to_flowi(flp));
that is fundamentally how VRF works. I would love to add the original
vrf port index to flowi4 for consideration with bind to device within a
VRF. I suspect your proposed patch is doing something close.
prev parent reply other threads:[~2022-03-12 0:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 22:31 vrf and multicast problem Ben Greear
2022-03-10 3:54 ` David Ahern
2022-03-10 19:33 ` Ben Greear
2022-03-10 20:03 ` David Ahern
2022-03-10 23:41 ` Ben Greear
2022-03-11 1:41 ` Ben Greear
2022-03-11 2:41 ` Ben Greear
2022-03-12 0:36 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ab5052-51ac-81d6-c65e-cfcfede3297a@gmail.com \
--to=dsahern@gmail.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).