From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C58C43381 for ; Sun, 17 Feb 2019 21:37:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42DDB21855 for ; Sun, 17 Feb 2019 21:37:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HRuu1MjN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbfBQVhb (ORCPT ); Sun, 17 Feb 2019 16:37:31 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:33292 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbfBQVha (ORCPT ); Sun, 17 Feb 2019 16:37:30 -0500 Received: by mail-ot1-f65.google.com with SMTP id i20so25224756otl.0 for ; Sun, 17 Feb 2019 13:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IS8CvpD28YS7F5Y4WGSufyBvUhErGpFMrPWQcStEXxk=; b=HRuu1MjNyUwC4H85mqptVgTllvLofJYM+lu+fdWtpthQLyrGRD03oKC8nb8t2hHEDP 3nsjtFBbfTuyrYgniFx9iCazGn1EQ5egwgLsWcOBmGVN6QL5Lp6TBQEvyWp1AXMdeNK6 Ap2SbnBHv5J6zzi32uPPhQ5fyjQ3ui3ghRJmMXW2hflyTIFgZln812wR6Qb8IC2Abl9k s1MQS5QFqXww3iyqdjyyX2mYzZzDoSerm0pgN3PdQ3oGv6jPHrxKh0Ba0haaSmD9mrxU OpEwimrdivmz6jtYOtsWlKAP+p0N1MreTYZKhc92BwjLd/2v1mal1wGeIfGQxdAZ2vo1 yFlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=IS8CvpD28YS7F5Y4WGSufyBvUhErGpFMrPWQcStEXxk=; b=pHcEu5yztAAtv6dd3ljN9Vwre9K5XnZ/OEO1mBXZrL5ZGjdLaGZRExb1CMJV2cAHGJ RUOONqQgCda+07Q1+jDCiO91sX6FNXyu3wivcp0EJ62O4z7dY0yGEmPisoXiWoU0PYEB wMi6i16AHSheIMcyXchoXqSdUto9g2otpDSHBBMfHaTYJFhIDtJFgAN6WPUPtj7eqsyo 1K82VlN7F3WKHT1K19sSoJnSPL6KoNMsoIE270wM99QnSdrHLPlVoyDXtXYmQMG8jh3F KRAUYFGpAMGheKwlmrSq0G3Ups97++LaP4ogQxawzhbxa9dOrStXE1n6pZu5cqbOMYha 5pPQ== X-Gm-Message-State: AHQUAuYh//dAyu9XzpkWYJDoFmffm9AthuzrMki35wKOooqFgUWm6iWi OUFZMBWf/qSQ9ZdmC9hmy+YXM9aX X-Google-Smtp-Source: AHgI3IaUGkBYnVy04a9wJKQgKvxcx+R8vaA+/YZCy2OlN24UGIzrneMfk4WLXs+4a9V8Q0/j/OHNHg== X-Received: by 2002:aca:a88a:: with SMTP id r132mr6491808oie.136.1550439449396; Sun, 17 Feb 2019 13:37:29 -0800 (PST) Received: from [192.168.1.3] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.gmail.com with ESMTPSA id q10sm4953073otl.15.2019.02.17.13.37.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 13:37:28 -0800 (PST) Subject: Re: [PATCH net-next 1/3] net: dsa: add support for bridge flags To: Russell King , Andrew Lunn , Vivien Didelot Cc: "David S. Miller" , netdev@vger.kernel.org References: <20190217142414.cjtmpi5y2l5rtdlb@shell.armlinux.org.uk> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0KEZsb3JpYW4gRmFpbmVsbGkgPGZhaW5lbGxpQGJyb2FkY29tLmNvbT6JAccEEAECALEF AlPAG9YXCgABv0jL/n0t8VEFmtDa8j7qERo7AN0gFAAAAAAAFgABa2V5LXVzYWdlLW1hc2tA cGdwLmNvbY4wFIAAAAAAIAAHcHJlZmVycmVkLWVtYWlsLWVuY29kaW5nQHBncC5jb21wZ3Bt aW1lCAsJCAcDAgEKAhkBBReAAAAAGRhsZGFwOi8va2V5cy5icm9hZGNvbS5jb20FGwMAAAAD FgIBBR4BAAAABBUICQoACgkQgTG1xCm8ZqD+Dgf9HhhzqvJYIPomNeg+ll7/TbzWb871E+HQ TaufJQFQwLEbgdFSZO2uj4UqfDpCyTwtHTVMJogWt3pCAE1sadeIY8OlT6918ofKIl8AiHj2 BlfL7ASZ5wzkRMt/4TZoinq9O1tPEynb5G6PdZTV3UQtmSGnpt2EOu7KtRJsnThBiXoOO9TJ Asg4vXJ0ZM1y/MPhQlZbPCHQZFe1gaVWBPLGnLyWyeprqgSLWHaGqrUhlfK1sLuJK1bjYDCI NetK0pS4cA4ZJgogr5FrtV64R19zLl02mt/Yj7rAmjC3ZBuwVi3V35kD8Kd4d9QM2apsiILV bzGbtVCSUgvxI+1SsJEm3bkBDQRTwBvBAQgArGvvWip77T4xgJztZp9YRylAcVTC9gtx0Gg6 eYk/EPANGm9TkuGpI++T/Il2H2TjFQNC7eubWohbYj0+6Tmf8nP+VmyobDxPXcMrK7x4xy9o D+Kub2Vf0SXbsM8fL/SqzGbFWZSm73L1L4GZoxvYIz0i7LExYSX2u5YVLaMBaH9HwKt2cvr7 MuTrRHtcbOZImoXT29g2UnoF1uwxYNeRhZY/lRvVkkY0lDipPuDwg3SpfHMtCybPq1uAswQd gEbHzRsEXwCR1OF3pIuGt4I3tSEhH/k1caqi0BlqjbGUOkku44xC2gf1ZU267FBBkdV3yJ/7 KnrJEnkMCYhS3kII9wARAQABiQJBBBgBAgErBQJTwBvCBRsMAAAAwF0gBBkBCAAGBQJTwBvB AAoJEJNgBqiYLw9VDRUIAJaTef6hsUAESnlGDpC+ymL2RZdzAJx9lXjU4hhaFcyhznuyyMJq d3mehmLxsqDRvHDiqyD71w2Bnc838MVZw0pwBPdnb/h9Ocmp0lL/9hwSGWvy4az5lYVyoA9u 14UIzh0YNGu6jr0isd/LJAbHXqwJwWWs3y8PTrpEp68V6lv+aXt5gR03lJEAvIR1Awp4JJ/e Z5y12gQISp0X8xal9YhhDWER92YLYrO2b6Hc2S31lAupzfCw8lmZsP1PRz1GmF/KmDD9J9N/ b8IehhWQqrBQjMjn2K2XkvN75HnAMHKFYfHZR3ZHtK52ZP1crV7THtbtrnPXVDq+vO4QPmdC +SEACgkQgTG1xCm8ZqC6BwgAl3kRh7oozpjpG8jpO8en5CBtTl3G+OpKJK9qbQyzdCsuJ0K1 qe1wZPZbP/Y+VtmqSgnExBzjStt9drjFBK8liPQZalp2sMlS9S7csSy6cMLF1auZubAZEqpm tpXagbtgR12YOo57Reb83F5KhtwwiWdoTpXRTx/nM0cHtjjrImONhP8OzVMmjem/B68NY++/ qt0F5XTsP2zjd+tRLrFh3W4XEcLt1lhYmNmbJR/l6+vVbWAKDAtcbQ8SL2feqbPWV6VDyVKh ya/EEq0xtf84qEB+4/+IjCdOzDD3kDZJo+JBkDnU3LBXw4WCw3QhOXY+VnhOn2EcREN7qdAK w0j9Sw== Message-ID: Date: Sun, 17 Feb 2019 13:37:19 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/17/2019 6:25 AM, Russell King wrote: > The Linux bridge implementation allows various properties of the bridge > to be controlled, such as flooding unknown unicast and multicast frames. > This patch adds the necessary DSA infrastructure to allow the Linux > bridge support to control these properties for DSA switches. > > We implement this by providing two new methods: one to get the switch- > wide support bitmask, and another to set the properties. > > Signed-off-by: Russell King > --- [snip] > > +int dsa_port_bridge_flags(const struct dsa_port *dp, unsigned long flags, > + struct switchdev_trans *trans) > +{ > + struct dsa_switch *ds = dp->ds; > + int port = dp->index; > + > + if (switchdev_trans_ph_prepare(trans)) > + return ds->ops->port_bridge_flags ? 0 : -EOPNOTSUPP; > + > + if (ds->ops->port_bridge_flags) > + ds->ops->port_bridge_flags(ds, port, flags); If you have a switch fabric with multiple switches, it seems to me that you also need to make sure that the DSA and CPU ports will have compatible flooding attribute, so just like the port_vlan_add() callback, you probably need to make this a switch fabric-wide event and use a notifier here. At least the DSA ports need to have MC flooding turned on for an user port to also have MC flooding working. Other than that LGTM. -- Florian