From: subashab@codeaurora.org
To: Lorenzo Colitti <lorenzo@google.com>
Cc: David Ahern <dsa@cumulusnetworks.com>,
Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, netdev-owner@vger.kernel.org
Subject: Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY
Date: Tue, 17 May 2016 12:35:53 -0600 [thread overview]
Message-ID: <a3cafb2342fa6a754fc389947f77f248@codeaurora.org> (raw)
In-Reply-To: <CAKD1Yr0E9i0s0ocSyYhEjODnVVQVBPOfbepvORAhT9gi9Qqz6A@mail.gmail.com>
On 2016-05-16 20:29, Lorenzo Colitti wrote:
> On Tue, May 17, 2016 at 11:24 AM, David Ahern <dsa@cumulusnetworks.com>
> wrote:
>> As I mentioned we can print the unsupported once or per socket matched
>> and
>> with the socket params. e.g.,
>>
>> + } else if (errno == EOPNOTSUPP) {
>> + printf("Operation not supported for:\n");
>> + inet_show_sock(h, diag_arg->f,
>> diag_arg->protocol);
>>
>> Actively suppressing all error messages is just wrong. I get the
>> flooding
>> issue so I'm fine with just printing it once.
>
> I disagree, but then I'm the one who wrote it in the first place, so
> you wouldn't expect me to agree. :-) Let's see what Stephen says.
Hi Lorenzo
Would it be acceptable to have a separate column which displays the
result of the sock destroy operation per socket.
State ... Killed
ESTAB Y
TIME_WAIT N
If it is not supported from kernel, maybe print U (unsupported) for
this.
next prev parent reply other threads:[~2016-05-17 18:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 23:53 [PATCH] net: diag: Tell user if support for destroying TCP sockets is not enabled David Ahern
2016-05-16 23:53 ` [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY David Ahern
2016-05-17 1:01 ` Lorenzo Colitti
2016-05-17 1:14 ` David Ahern
2016-05-17 1:20 ` Lorenzo Colitti
2016-05-17 1:52 ` David Ahern
2016-05-17 2:04 ` Lorenzo Colitti
2016-05-17 2:24 ` David Ahern
2016-05-17 2:29 ` Lorenzo Colitti
2016-05-17 18:35 ` subashab [this message]
2016-05-18 18:51 ` Stephen Hemminger
2016-05-19 0:55 ` Lorenzo Colitti
2016-05-19 3:02 ` David Ahern
2016-05-19 3:47 ` Eric Dumazet
2016-05-19 4:05 ` David Ahern
2016-05-19 4:12 ` Eric Dumazet
2016-05-19 14:06 ` David Ahern
2016-05-19 15:19 ` Eric Dumazet
2016-05-19 15:22 ` Lorenzo Colitti
2016-05-17 0:49 ` [PATCH] net: diag: Tell user if support for destroying TCP sockets is not enabled Lorenzo Colitti
2016-05-17 1:11 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3cafb2342fa6a754fc389947f77f248@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=dsa@cumulusnetworks.com \
--cc=lorenzo@google.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).