netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Walker <danielwa@cisco.com>
To: Duan Jiong <duanj.fnst@cn.fujitsu.com>,
	"David S. Miller" <davem@davemloft.net>,
	Poornima Ranganath <pooranga@cisco.com>,
	xe-linux-external@cisco.com, netdev@vger.kernel.org
Subject: Re: ipv4: distinguish EHOSTUNREACH from the ENETUNREACH
Date: Mon, 14 Aug 2017 13:35:24 -0700	[thread overview]
Message-ID: <a3d81771-62d2-f213-c98b-d9bb47cfb234@cisco.com> (raw)

Hi,


It seems like commit cd0f0b is trying to add back these two errors 
values into ip_route_input_slow(). However, if you follow the code path 
further down you get to the two exit points of this function,

in net/ipv4/route.c:ip_route_input_slow()

if (rt_cache_valid(rth)) {
	skb_dst_set_noref(skb, &rth->dst);
	err = 0;
	goto out;
}

and

skb_dst_set(skb, &rth->dst);
err = 0;
goto out;

Both of these set "err" variable to 0. This effective destroys the 
return value which the patch seems to be adding. Am I missing something 
here?


Thanks,

Daniel

                 reply	other threads:[~2017-08-14 20:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3d81771-62d2-f213-c98b-d9bb47cfb234@cisco.com \
    --to=danielwa@cisco.com \
    --cc=davem@davemloft.net \
    --cc=duanj.fnst@cn.fujitsu.com \
    --cc=netdev@vger.kernel.org \
    --cc=pooranga@cisco.com \
    --cc=xe-linux-external@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).