From: Andrew Lunn <andrew@lunn.ch>
To: Jiawen Liu <1298662399@qq.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH] net: renesas: rswitch-main: fix runtime PM cleanup
Date: Tue, 18 Aug 2026 17:00:29 +0200 [thread overview]
Message-ID: <a402f04d-a919-4bde-b15e-b02c06ae1ebd@lunn.ch> (raw)
In-Reply-To: <tencent_2EBD0396FF7A54CAD61F16E942D2E8FA3A0A@qq.com>
On Tue, Aug 18, 2026 at 04:41:35PM +0400, Jiawen Liu wrote:
> From: jiawen <1298662399@qq.com>
>
> Update renesas_eth_sw_probe() for the confirmed driver lifecycle defect.
>
> Keep the change limited to the concrete operation shown in the final
> patch.
>
> Signed-off-by: jiawen <1298662399@qq.com>
> ---
> diff --git a/drivers/net/ethernet/renesas/rswitch_main.c b/drivers/net/ethernet/renesas/rswitch_main.c
> --- a/drivers/net/ethernet/renesas/rswitch_main.c
> +++ b/drivers/net/ethernet/renesas/rswitch_main.c
> @@ -2123,6 +2123,8 @@
> { /* Sentinel */ }
> };
>
> +static void rswitch_deinit(struct rswitch_private *priv);
> +
Please don't add forward references. Add a patch which first moves
this function earlier. Then fix the issue.
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2026-08-18 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 12:41 [PATCH] net: renesas: rswitch-main: fix runtime PM cleanup Jiawen Liu
2026-08-18 13:01 ` Michael Dege
2026-08-18 13:06 ` Geert Uytterhoeven
2026-08-18 15:00 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a402f04d-a919-4bde-b15e-b02c06ae1ebd@lunn.ch \
--to=andrew@lunn.ch \
--cc=1298662399@qq.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox