From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH bpf-next] tools: include reallocarray feature test in FEATURE_TESTS_BASIC Date: Fri, 13 Jul 2018 19:26:48 -0700 Message-ID: References: <20180714020859.11306-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: oss-drivers@netronome.com, netdev@vger.kernel.org To: Jakub Kicinski , alexei.starovoitov@gmail.com, daniel@iogearbox.net Return-path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:37852 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731042AbeGNCoJ (ORCPT ); Fri, 13 Jul 2018 22:44:09 -0400 Received: by mail-pg1-f193.google.com with SMTP id e9-v6so262758pgs.4 for ; Fri, 13 Jul 2018 19:26:52 -0700 (PDT) In-Reply-To: <20180714020859.11306-1-jakub.kicinski@netronome.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/13/2018 07:08 PM, Jakub Kicinski wrote: > perf propagates its feature check results to libbpf. This means > features for which perf probes must be a superset of libbpf's > required features. perf depends on FEATURE_TESTS_BASIC for its list > of features. > > commit 531b014e7a2f ("tools: bpf: make use of reallocarray") added > reallocarray use to libbpf, make perf also perform the reallocarray > feature check. > > Fixes: 531b014e7a2f ("tools: bpf: make use of reallocarray") > Reported-by: Guenter Roeck > Signed-off-by: Jakub Kicinski Tested-by: Guenter Roeck > --- > tools/build/Makefile.feature | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > index 5b6dda3b1ca8..f216b2f5c3d7 100644 > --- a/tools/build/Makefile.feature > +++ b/tools/build/Makefile.feature > @@ -57,6 +57,7 @@ FEATURE_TESTS_BASIC := \ > libunwind-aarch64 \ > pthread-attr-setaffinity-np \ > pthread-barrier \ > + reallocarray \ > stackprotector-all \ > timerfd \ > libdw-dwarf-unwind \ >