From: David Ahern <dsahern@kernel.org>
To: Oscar Maes <oscmaes92@gmail.com>,
netdev@vger.kernel.org, bacs@librecast.net, brett@librecast.net,
kuba@kernel.org
Cc: davem@davemloft.net, regressions@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH net v3 1/2] net: ipv4: fix regression in local-broadcast routes
Date: Wed, 27 Aug 2025 10:09:48 -0600 [thread overview]
Message-ID: <a42b28d5-e81e-4131-8c00-8925b097070a@kernel.org> (raw)
In-Reply-To: <20250827062322.4807-1-oscmaes92@gmail.com>
On 8/27/25 12:23 AM, Oscar Maes wrote:
> Commit 9e30ecf23b1b ("net: ipv4: fix incorrect MTU in broadcast routes")
> introduced a regression where local-broadcast packets would have their
> gateway set in __mkroute_output, which was caused by fi = NULL being
> removed.
>
> Fix this by resetting the fib_info for local-broadcast packets. This
> preserves the intended changes for directed-broadcast packets.
>
> Cc: stable@vger.kernel.org
> Fixes: 9e30ecf23b1b ("net: ipv4: fix incorrect MTU in broadcast routes")
> Reported-by: Brett A C Sheffield <bacs@librecast.net>
> Closes: https://lore.kernel.org/regressions/20250822165231.4353-4-bacs@librecast.net
> Signed-off-by: Oscar Maes <oscmaes92@gmail.com>
> ---
> Link to discussion:
> https://lore.kernel.org/netdev/20250822165231.4353-4-bacs@librecast.net/
>
> Thanks to Brett Sheffield for finding the regression and writing
> the initial fix!
>
> net/ipv4/route.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2025-08-27 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 6:23 [PATCH net v3 1/2] net: ipv4: fix regression in local-broadcast routes Oscar Maes
2025-08-27 6:23 ` [PATCH net v3 2/2] selftests: net: add test for destination in broadcast packets Oscar Maes
2025-08-27 14:26 ` Brett A C Sheffield
2025-08-28 8:51 ` Paolo Abeni
2025-08-27 16:09 ` David Ahern [this message]
2025-08-28 9:00 ` [PATCH net v3 1/2] net: ipv4: fix regression in local-broadcast routes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a42b28d5-e81e-4131-8c00-8925b097070a@kernel.org \
--to=dsahern@kernel.org \
--cc=bacs@librecast.net \
--cc=brett@librecast.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oscmaes92@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).