From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 905BD211A00; Tue, 18 Mar 2025 17:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742317854; cv=fail; b=TgeOdGIdzQzRe9BCeP5rLpZaFvh7ey0mVgs8Ava2/6q04qqffIeDSeTuITblok8dB5cHd8hXRpAP9rt7nRpu8dnQ2D1IZc8MK8+5PmvT4ldKTRMXX5Eay+pLyhxqzTv6FPWYc7QjNPC109BBrbRiadLUcVga4m5QA422pZiBmYM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742317854; c=relaxed/simple; bh=tzwhIRnfiiQr8i9zjIIVUfnGXVGIbCP8UwoNTgXNPng=; h=Message-ID:Date:Subject:From:To:CC:References:In-Reply-To: Content-Type:MIME-Version; b=UN6vKQlNpNZQ5z5fZrk3Q65oVva6m9F/eL3hcwpIvAAlVmwmZ2qxY+w0N/2CVe3dRv5ha1XGqhjSC/lGgPM1iGuAoJlazeKcTN/ObSD1Ltadb40+8Fz9VohXgBwk9e+h0sYNj6Jol1eD2yYfbFZ+yxt+Ww2Yb86ykWtQLmnw2Bw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SAeRlN7K; arc=fail smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SAeRlN7K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742317853; x=1773853853; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=tzwhIRnfiiQr8i9zjIIVUfnGXVGIbCP8UwoNTgXNPng=; b=SAeRlN7KlN0KULHbGOl/Hb03WbKQ3EGNXF8k7H3D+RPE/rARpYQJGa9d ScyXa8JS2Bp5S4tYAM7osyHWDQqlZXwPnsK+bJCpf21SgcrnFLMtDtnad MSSSKedThL2PgU5W6Xg3E9PGACHHLTHVBMISHsmw9K1gnVlQ97otJwxZu 0fj2RhotHaiZMw6WO8NCGFsZx2nqDnOhYa6R0HqemJDVVPmLoarNIqNN0 5/gek0/L+CQymIQFxnoWpbA7D+FfKWCy3Qt4A6nKh/obKhGw1S/y4LgBe Isg4LJRd1ENyhN1TNKfLc2gcTc1f5FAdNVLixxm49DALaLr0ZIZHmTEZf w==; X-CSE-ConnectionGUID: AahSBrzZTh+tEEA+u2cIrQ== X-CSE-MsgGUID: 4XhI3L5VTpiEZaz/hVfQUA== X-IronPort-AV: E=McAfee;i="6700,10204,11377"; a="54854631" X-IronPort-AV: E=Sophos;i="6.14,257,1736841600"; d="scan'208";a="54854631" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2025 10:10:51 -0700 X-CSE-ConnectionGUID: pVqyuoxDTDmIE4gAX/CRqA== X-CSE-MsgGUID: J21gLsnYSL2uLInA8w8y8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,257,1736841600"; d="scan'208";a="127519113" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Mar 2025 10:10:51 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 18 Mar 2025 10:10:50 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Tue, 18 Mar 2025 10:10:50 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 18 Mar 2025 10:10:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j9wDHawtUHwwgUwAAi85B/reB5FeF/f3kraf/pKsmG3KDhx+A6BbGzxnN9KKx9g7lc1t24FHZ8Ayxn+NAj0gNZ1BaL9w9TRoGd5sEoRcEANBJUwuoi3MXG61Hw8DX1BZA8icqkWjSXLhbW56kLL+3Wz//N7aeKQ3QjwrMUfmrGX9VX48xZsz6VVF+0x0MVdiO67sb0Gr58j23zohBpPSK3v1JDkDhJxz6nch6xror9oSiRPaViDVADNxBR82o9BATfYdeWqVDeGImR1DheBB9uYXJPpHMDCmjVqTPfVMXUBp5Uv9MabqhXNPSGp5/teRRbiM+wNVpzxtnLz1WuqD0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fW9mK+n3S0qqYyu7JTrpTHPMzOKfr5YsLo2K0Cg6BzY=; b=B33imptq5VbpejP+3/yGQaYlaNwQRSZPY+h9NETU4ovKOSFxxYDCFspZ+8X8CVheLiFUjELdWnByvzFj2jyUF7dhHaaTIBW00qSwesoE4XQsD5zgA9Rgeu7XGjDzoDirSCvgNgg4qro6Ps58GElvUUSYHScoTfhF01z4SCGLc4+ObcG/X1K7PiGpSuXRFrmp2QXmxrFAVzIzGjbhq8wFSfM6MVFI/FL5cbTfYUcv9FqSEPk0XGBIs/q0sZyXWLmb5p1JPZ+0hzfnbKA6pvIcVCeaycPTC7T2foaBuazKubjM6RmMxA3ByTT7QAypcp4Ss1UKv1StH012OAkRlGldPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) by CH3PR11MB7251.namprd11.prod.outlook.com (2603:10b6:610:147::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33; Tue, 18 Mar 2025 17:10:46 +0000 Received: from DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::4b3b:9dbe:f68c:d808]) by DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::4b3b:9dbe:f68c:d808%5]) with mapi id 15.20.8534.031; Tue, 18 Mar 2025 17:10:45 +0000 Message-ID: Date: Tue, 18 Mar 2025 18:10:39 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 07/16] idpf: link NAPIs to queues From: Alexander Lobakin To: Eric Dumazet CC: , Michal Kubiak , Maciej Fijalkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Jakub Kicinski , "Paolo Abeni" , Alexei Starovoitov , "Daniel Borkmann" , Jesper Dangaard Brouer , John Fastabend , Simon Horman , , , References: <20250305162132.1106080-1-aleksander.lobakin@intel.com> <20250305162132.1106080-8-aleksander.lobakin@intel.com> <5c2dd43f-2890-44db-a5ab-68a86dd2d89a@intel.com> Content-Language: en-US In-Reply-To: <5c2dd43f-2890-44db-a5ab-68a86dd2d89a@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MI1P293CA0016.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:3::8) To DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB8718:EE_|CH3PR11MB7251:EE_ X-MS-Office365-Filtering-Correlation-Id: 96ba7c12-0aef-4fb7-8ec5-08dd663fd259 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SU45bi9QUWRWU3l6dVljMlRRRGxFZ3N5cWdIMHNBRUtKallBMS9sQlV2R3pJ?= =?utf-8?B?UU54UE5LY3pRYlIvek5GS01Mei9OMXd5ZzNGV2FXTXpmRklBZlRUOE1JdmFP?= =?utf-8?B?OU1QbTN5T2tKVkZOTmRKYmszZzVkV2ttTHlJUTZJdFJDWTRsb3BqRGdjWXdE?= =?utf-8?B?ZUhhN3gzMk1Pb3NwMk8yZVd1UHh1aWk2ZFJWZis4QmVZUk5uSHBndGVFUndO?= =?utf-8?B?SDF2OXN5VU9aaFJuVDlkKzVydThZV3VQM3Fsc3p3Z0NDNTh1eTZiTDhSOFlo?= =?utf-8?B?NkI5d1k4S1NrNGE0dkJ4dzFQWmZaU0Q0Vi90OVFnR2FYR0tUNmc1TFE5eXRQ?= =?utf-8?B?T0drdnBtK0tBZFdKL2VKT0djaG1IeURvbzg2bjY1S21HVldFcU8rc2dQNFk0?= =?utf-8?B?MERSWVQ4ZEVOc1Y1V2pPRy9Hb1hhcUo5WGdXeXlYRUNVTkx0UGgyYTlZeE1N?= =?utf-8?B?ODROZUJwWkpYRW1ITXkyQnpzcDdMUTJvVWxJTHNsWDUzZTBZb0d1UWNIUGg5?= =?utf-8?B?WnIrVWdISElJQ0lkU1VPOEJvRkpYZVAwS2ZmaDJoY0ZPaVpDbzBuek5aSk1a?= =?utf-8?B?WDFFUXMrTDFLM1Q0VFpnV09uN2xpY3dKRytvL1pqdENSTE0wczZvOStDMzdF?= =?utf-8?B?NFd4NHJlZVcwR2d4ZzE5YVVMM2s3Ym9CNHVNT0xQbWhNaGtnSWtNY053a0ZE?= =?utf-8?B?R1lIajVpcWwxS3RqWTAwNm42czBPS1NDaXA3QkRwbG5oMzdWdjNYeFVCd1lw?= =?utf-8?B?WVdmMTZmUWM2d1Rlc3IvUzBIOW5MTGZlaC9iWlJjcWtZRXpwVm1uVG5UQk5R?= =?utf-8?B?QXZCM0VIbWJkNmRWck5CblNlcEpuQ3RiSG5CSnNKZmNnL1JUWFdOcWJjeldu?= =?utf-8?B?ZE5PZjFIbGQvUE5kYm9BQXNmbW9DNkYrQ0drL242UVN3SEU2WGpZbkg1SU9L?= =?utf-8?B?dnpyMDBvdWpvRy9pMGFKV1IzZmVBVzJEVURxaXlmMStTYXVCVjBpSkNjalp1?= =?utf-8?B?M24wU2lXWXBaQVB0RXBMb21xOFpWWm1tdGZqWDJ0RVBxT01RR1dwSzdyK2Zm?= =?utf-8?B?YmlsaktHU2xXQ3p0c2RIb0ZvS3R2UFA0blB4MThrVFRVVm1MYTR4M3gxYm5s?= =?utf-8?B?MTR6c0NRcGkyRXdjL3o1cDNDN25nbGgzYzFjcHFrTE8zMHlrem9QQVdmNlBL?= =?utf-8?B?aGw1TVBneTcrSkxtS0ZVdCtGbmxhampwT0R6Mlc1VE43NVVFSU5jU1d4YVhz?= =?utf-8?B?YjdJdFVrQ0VGQ21jeFM0OXZBUU5ZL0FwWk55ckNsYVIxV1JrdjRhK1poNThU?= =?utf-8?B?M0RpQ1ZXem14OEdzMFFuU25CYXFKZm9YZmduL1JUd0hIRUVDSEN3bERLdDF3?= =?utf-8?B?Y3RpWDZoNzhSbkVnS0wxeU9SZWtMSTcvM1gxTnJLNmI0RitBbS9IV1JIZE40?= =?utf-8?B?WldLSG5ybUMwUFpHdzM0WnkxWkdRM2d6RWpwRVFrZWNHdFp0N2JVTjZxZjc4?= =?utf-8?B?OVBNUWhHTXE2dTc2VFBaV1ZicUZ6WjlRVThKenlsb1pYN25WUzA4NDBtS3Zr?= =?utf-8?B?ZkFRL3l6KzdIWDg1WkhYbjJNWGJBOStyRTFMam1NZHhQcnlPYTdHamlyTTYz?= =?utf-8?B?cDJNYzkxSGd2MXV0NlNhK2QrM2ZzN3VybEROKzIrTlBuWnVFL25RWXB0dkNv?= =?utf-8?B?cWdsaGhieWlBYmM3VXROai85bFl0ODlkS0hNZEFlRTJuRzJ3VjlITnFvQ21S?= =?utf-8?B?UDhxRms5WjVtV1V2akhwRzF5ek5sSGpGMGNPTDUyME1SVHBDVnJnSktHbVgz?= =?utf-8?B?Zk01UTg2dTFpejJUaE1NcUNnelUrQ1dlMndqSlRqUGdRbzRuQjVSdUlWc2Jo?= =?utf-8?Q?5LSbEQ5YqjA9c?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB8718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDBvYVlRUTRKaW5ydGQ0TERneERJVGhrTFltVzNmQnNJUFRRQS9BUGE5bUhP?= =?utf-8?B?QnpabzFGWUlJVGNJL3N0b3lPTWFBaVl3Z1FLRFFEdmZDYWg2VzUxQitHWkRD?= =?utf-8?B?SHM2SERzM2lxOUppNHA3SEh2ZDRlS1NZb280eXV3WVZ5NzlLVTZDMjBqV3Vt?= =?utf-8?B?aFBvYTVmOFoxNms2RXV1UUErMU1ZbGtPZDBTejM0VEdQZUhndEJNU1Y4MWRF?= =?utf-8?B?a2E5a0R1UGhKZDFEdU81SGRqdFBpcHc0VTZzaVFESmxubU5BY1ZzNU1OUk5J?= =?utf-8?B?KzVCT2tTZFpmazhZbWNiV2VLSUQvTUZSNjg0RkdJbVZZRUpFZnRoNkxOUGNo?= =?utf-8?B?WHltT05BZTNiQmRrL3FzcFRQVUo2WDFwSU43UnQwMzdWVXI1emQwUk9hU1ha?= =?utf-8?B?YUJZYVhvM0xFNGJvcEFRd3V2R3ZVZEpHQkJJVWVyYTRJMHdNRSt0U3grUzMx?= =?utf-8?B?SHI4QzZTdzRoZ2VpeERzQnpMRkVuMGpwMXZHNDJYK3liSXJ3TVFETVQ0R25k?= =?utf-8?B?enBMWkdvWGN2TXd6NnJ3ajlvTDNHejBUc0t3ZnB3SlhrTXpsVWg3Q2t4Ti9n?= =?utf-8?B?ak9SVGo1YnF5RVhUWC9iV081LzZsbytObzFJUHBsSHNFbVNDeFpnV2RiZkFn?= =?utf-8?B?bzBSRktuUzJGczJ0OEFMWGZPUU9QQnF1MkVpTlNZRXk2NUtzajMzMXIwL0Qv?= =?utf-8?B?VUxQMU53UzdqdGF1emdBNHhaaE85TEY4YjNtN0VlUnpyZEpZZWF4c1F6K25q?= =?utf-8?B?STQ4UVlIeXhTSk9KRXJYakdoM2VPcjg2YU1QUjc4UVlsaFpUQzMzTnhFZlFR?= =?utf-8?B?THRqdFQzYkJOUlQvRmZxMTdxQ1JWUlpKRm1xL1RoKzgwbUd5UU1zS0ZSUFBO?= =?utf-8?B?Qjk0ZHExdE9ma0F3b0VycmxIZDQ1NERnSmd6eVRlbCt0UmhadlIzVmdlSk5R?= =?utf-8?B?MFJVZ1NSb2VWdENBWEZsSFB5MWxmNE1qc2ROd3JiZWtSMExZSHBGVmREaDhZ?= =?utf-8?B?RWZnOXB0Z3JyVXJ6cVZpejE0aCttODVNY0dqd0lQYk96a09DeHpFeWJQNCtk?= =?utf-8?B?czdUNVExTFArUXhiMjhhWlFKQnl2SjdwVnNHUUM4blBaYXJwRTdjRmlSNkNl?= =?utf-8?B?NFlLRkZtQjVUU2dXWnNPbHRUeGxQUjJuTkdQTGt3aGZ1a3pvcVlMbEgzN3ZB?= =?utf-8?B?dEZwSmhSclNoMkNXRWpwUXorYTRJV2JLK3RoSjl0WHpvbFdsTXJMbVBHNWhw?= =?utf-8?B?bWFrOHppTkFhMjBaWWFWS0ZGMmx4YW1jNXZibTVyUCtYbDJFT2VKd2s1NmJ6?= =?utf-8?B?L1RzSGxPeVFNYlU1QWlVUXM1OE5WODRzMHBsNVc5NWJLczJaRFl0dG5uTFcr?= =?utf-8?B?Mnh5RjNEQ0hMTXhwVFlCenZiOW0wc2dNV2FSSU9sY1VOYU5vMldLRFMvRzJv?= =?utf-8?B?aHN6RHVMUjVackhoZlMxR21NMjFLSFlOVWg3ZUNMUWVHQnAvYVRwR2RmTUlz?= =?utf-8?B?Z3lWREZvcVloUkVqVXZwZVJUczMyTTQ2YWM1UXNTNVhuUEJFWHhqV0F2OUlS?= =?utf-8?B?M3hZUDVkRmUzYmt5am82anZ1REg2UlBkRTVUMms4RTlvdWNIaldkeVlGV0Fs?= =?utf-8?B?ZDhjam1yb1BZcEpKZGV1aDdKQVJTNEpBZGcvbjZCV1ZOMHRueGcrcmZkd0N3?= =?utf-8?B?QVVEcmY3OXdRSG1NVHREcmtMWnVqODVkZXhLTlZha0Q4QitYYVZFTDlVaWNZ?= =?utf-8?B?QUhTbDJMSlYxeXl0QVpxQUN3bzhFT1FFa2twL2ZTZm9VLzFCZE1WVjh2KzVk?= =?utf-8?B?R3RwbW9FMTA2Y1c4WmxJZUJEbG1QSmd2VUhmTTRCUXVxQmRqLzJCY3pzYlFG?= =?utf-8?B?OHA4d0Q5NFhidStSVUdRK25uZWRsL0hvQ1RXWE9VbFQzU1huMGhaVnpYYis4?= =?utf-8?B?U2tvckFHeDV5TlMzVllMN0FEdmxpTE9CZnFuRVVXVFdaYTZ0N24yRm9ZeWxJ?= =?utf-8?B?SkQwRkovQjJ6aFcwd3hnQzRTNEpmV0Y5VjFvV0o1UnQ5aGdSRmpkNzFTVmZF?= =?utf-8?B?SEFvMDdGWVM4QUJITTZxdEdCbDBQZGlUTFpxWUlSNlR6cVEyTWtIQW1nNnBE?= =?utf-8?B?WE8vbTF1VUdSZE9Zazh2LzBxQkJydTU3djNkRldDV3NlVXNjNWQzcjhhZGc3?= =?utf-8?B?NGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 96ba7c12-0aef-4fb7-8ec5-08dd663fd259 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2025 17:10:45.8499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kc2AGHlXrIpXm38xS3uI5PEHkvAwBVjhrHASf4dfCX9bdZOPzPo6lmoU7LpPo5LmcQrVBdHBqxSIThcnip+j/OoFcBjqtym3HHbt7dPn04w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7251 X-OriginatorOrg: intel.com From: Alexander Lobakin Date: Wed, 12 Mar 2025 18:16:11 +0100 > From: Eric Dumazet > Date: Fri, 7 Mar 2025 11:28:36 +0100 > >> On Wed, Mar 5, 2025 at 5:22 PM Alexander Lobakin >> wrote: >>> >>> Add the missing linking of NAPIs to netdev queues when enabling >>> interrupt vectors in order to support NAPI configuration and >>> interfaces requiring get_rx_queue()->napi to be set (like XSk >>> busy polling). >>> >>> Signed-off-by: Alexander Lobakin >>> --- >>> drivers/net/ethernet/intel/idpf/idpf_txrx.c | 30 +++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> >>> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c >>> index 2f221c0abad8..a3f6e8cff7a0 100644 >>> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c >>> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c >>> @@ -3560,8 +3560,11 @@ void idpf_vport_intr_rel(struct idpf_vport *vport) >>> static void idpf_vport_intr_rel_irq(struct idpf_vport *vport) >>> { >>> struct idpf_adapter *adapter = vport->adapter; >>> + bool unlock; >>> int vector; >>> >>> + unlock = rtnl_trylock(); >> >> This is probably not what you want here ? >> >> If another thread is holding RTNL, then rtnl_ttrylock() will not add >> any protection. > > Yep I know. trylock() is because this function can be called in two > scenarios: > > 1) .ndo_close(), when RTNL is already locked; > 2) "soft reset" aka "stop the traffic, reallocate the queues, start the > traffic", when RTNL is not taken. > > The second one spits a WARN without the RTNL being locked. So this > trylock() will do nothing for the first scenario and will take the lock > for the second one. > > If that is not correct, let me know, I'll do it a different way (maybe > it's better to unconditionally take the lock on the callsite for the > second case?). Ping. What should I do, lock RTNL on the callsite or proceed with trylock? Thanks, Olek