From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Beregalov Subject: Re: [PATCH] ioatdma: fix "ioatdma frees DMA memory with wrong function" Date: Tue, 12 May 2009 14:03:25 +0400 Message-ID: References: <20090423123128.31427.20238.stgit@linux.site> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: dan.j.williams@intel.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Maciej Sosnowski Return-path: Received: from mail-fx0-f158.google.com ([209.85.220.158]:47120 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754018AbZELKD0 (ORCPT ); Tue, 12 May 2009 06:03:26 -0400 In-Reply-To: <20090423123128.31427.20238.stgit@linux.site> Sender: netdev-owner@vger.kernel.org List-ID: 2009/4/23 Maciej Sosnowski : > as reported by Alexander Beregalov > > ioatdma 0000:00:08.0: DMA-API: device driver frees DMA memory with > wrong function [device address=0x000000007f76f800] [size=2000 bytes] > [map > ped as single] [unmapped as page] > > The ioatdma driver was unmapping all regions > (either allocated as page or single) using unmap_page. > This patch lets dma driver recognize if unmap_single or unmap_page should be used. > It introduces two new dma control flags: > DMA_COMPL_SRC_UNMAP_SINGLE and DMA_COMPL_DEST_UNMAP_SINGLE. > They should be set to indicate dma driver to do dma-unmapping as single > (first one for the source, tha latter for the destination). > If respective flag is not set, the driver assumes dma-unmapping as page. > > Signed-off-by: Maciej Sosnowski > Acked-by: Dan Williams > Reported-by: Alexander Beregalov > Tested-by: Alexander Beregalov > --- Will it be sent to Linus ?