netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: syzbot <syzbot+4386709c0c1284dca827@syzkaller.appspotmail.com>,
	davem@davemloft.net, linux-can@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	socketcan@hartkopp.net, syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in can_rcv
Date: Tue, 16 Jan 2018 19:07:46 +0100	[thread overview]
Message-ID: <a48197ff-9270-8af7-a814-56af53093b3c@pengutronix.de> (raw)
In-Reply-To: <001a11c16b40d795350562e878cc@google.com>


[-- Attachment #1.1: Type: text/plain, Size: 1495 bytes --]

On 01/16/2018 06:58 PM, syzbot wrote:
> Hello,
> 
> syzkaller hit the following crash on  
> a8750ddca918032d6349adbf9a4b6555e7db20da
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master
> compiler: gcc (GCC) 7.1.1 20170620
> .config is attached
> Raw console output is attached.
> C reproducer is attached
> syzkaller reproducer is attached. See https://goo.gl/kgGztJ
> for information about syzkaller reproducers
> 
> 
> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+4386709c0c1284dca827@syzkaller.appspotmail.com
> It will help syzbot understand when the bug is fixed. See footer for  
> details.
> If you forward the report, please keep this part and the footer.
> 
> device eql entered promiscuous mode
> ------------[ cut here ]------------
> PF_CAN: dropped non conform CAN skbuf: dev type 65534, len 42, datalen 0
> WARNING: CPU: 0 PID: 3650 at net/can/af_can.c:729 can_rcv+0x1c5/0x200  
> net/can/af_can.c:724
> Kernel panic - not syncing: panic_on_warn set ...

Invalid packages generate a warning (WARN_ONCE()), and you have
panic_on_warn active. Should we better silently drop these CAN packages?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-01-16 18:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 17:58 WARNING in can_rcv syzbot
2018-01-16 18:07 ` Marc Kleine-Budde [this message]
2018-01-16 18:11   ` Dmitry Vyukov
2018-01-16 18:44     ` Marc Kleine-Budde
2018-01-17  6:39     ` Oliver Hartkopp
2018-01-17  7:12       ` Eric Biggers
2018-01-17  7:39         ` Dmitry Vyukov
2018-01-17  8:22           ` Oliver Hartkopp
2018-01-17  8:46             ` Dmitry Vyukov
2018-01-17  8:07         ` Oliver Hartkopp
2018-01-17  9:43           ` Marc Kleine-Budde
2018-01-17 16:29             ` Oliver Hartkopp
2018-01-17 17:12               ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a48197ff-9270-8af7-a814-56af53093b3c@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=davem@davemloft.net \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=syzbot+4386709c0c1284dca827@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).