From: Thomas Falcon <tlfalcon@linux.ibm.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, liuhangbin@gmail.com,
davem@davemloft.net, joe@perches.com
Subject: Re: [PATCH net v2] ibmveth: Convert multicast list size for little-endian system
Date: Wed, 14 Aug 2019 10:41:20 -0500 [thread overview]
Message-ID: <a496c317-264a-ee1a-238a-4043eb4fcb3e@linux.ibm.com> (raw)
In-Reply-To: <20190813194037.464bea2c@cakuba.netronome.com>
On 8/13/19 9:43 PM, Jakub Kicinski wrote:
> On Mon, 12 Aug 2019 16:13:06 -0500, Thomas Falcon wrote:
>> The ibm,mac-address-filters property defines the maximum number of
>> addresses the hypervisor's multicast filter list can support. It is
>> encoded as a big-endian integer in the OF device tree, but the virtual
>> ethernet driver does not convert it for use by little-endian systems.
>> As a result, the driver is not behaving as it should on affected systems
>> when a large number of multicast addresses are assigned to the device.
>>
>> Reported-by: Hangbin Liu <liuhangbin@gmail.com>
>> Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
> Okay, applied, but:
Thanks!
...
> ibmveth_init_link_settings() is part of your net-next patch which
> you're respining, so I had to apply manually. Please double check your
> patches apply cleanly to the designated tree.
Sorry about that, I thought I fixed that but maybe I got patches mixed
up somehow. Thanks again.
Tom
next prev parent reply other threads:[~2019-08-14 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 21:13 [PATCH net v2] ibmveth: Convert multicast list size for little-endian system Thomas Falcon
2019-08-14 2:43 ` Jakub Kicinski
2019-08-14 15:41 ` Thomas Falcon [this message]
2019-08-14 3:35 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a496c317-264a-ee1a-238a-4043eb4fcb3e@linux.ibm.com \
--to=tlfalcon@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=joe@perches.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox