netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Joshua Hay <joshua.a.hay@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v8 3/9] idpf: move queue resources to idpf_q_vec_rsrc structure
Date: Wed, 15 Oct 2025 09:22:14 +0200	[thread overview]
Message-ID: <a49a045c-b01a-48d2-a02c-23540f799f8a@molgen.mpg.de> (raw)
In-Reply-To: <20251013231341.1139603-4-joshua.a.hay@intel.com>

Dear Joshua,


Thank you for the patch.

Am 14.10.25 um 01:13 schrieb Joshua Hay:
> From: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
> 
> Move both TX and RX queue resources to the newly introduced
> idpf_q_vec_rsrc structure.

What is the motivation for doing this?


> While at it, declare the loop iterator in loop and use the correct type.

Please make this a separate commit, as the diff is already big enough.


Kind regards,

Paul


> Reviewed-by: Anton Nadezhdin <anton.nadezhdin@intel.com>
> Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
> Signed-off-by: Joshua Hay <joshua.a.hay@intel.com>
> ---
> v8:
> - rebase on AF_XDP series
> - remove dev param from rx_desc_rel and access through q_vector
> - introduce per queue RSC flag to avoid vport check
> ---
>   drivers/net/ethernet/intel/idpf/idpf.h        |  69 +--
>   .../net/ethernet/intel/idpf/idpf_ethtool.c    |  91 ++--
>   drivers/net/ethernet/intel/idpf/idpf_lib.c    |  71 +--
>   drivers/net/ethernet/intel/idpf/idpf_ptp.c    |  17 +-
>   drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 451 +++++++++---------
>   drivers/net/ethernet/intel/idpf/idpf_txrx.h   |  21 +-
>   .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 258 +++++-----
>   .../net/ethernet/intel/idpf/idpf_virtchnl.h   |  12 +-
>   drivers/net/ethernet/intel/idpf/xdp.c         |  37 +-
>   drivers/net/ethernet/intel/idpf/xdp.h         |   6 +-
>   drivers/net/ethernet/intel/idpf/xsk.c         |   7 +-
>   11 files changed, 561 insertions(+), 479 deletions(-)

[…]

  reply	other threads:[~2025-10-15  7:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 23:13 [Intel-wired-lan][PATCH iwl-next v8 0/9] refactor IDPF resource Joshua Hay
2025-10-13 23:13 ` [Intel-wired-lan][PATCH iwl-next v8 1/9] idpf: introduce local idpf structure to store virtchnl queue chunks Joshua Hay
2025-10-13 23:13 ` [Intel-wired-lan][PATCH iwl-next v8 2/9] idpf: introduce idpf_q_vec_rsrc struct and move vector resources to it Joshua Hay
2025-10-13 23:13 ` [Intel-wired-lan][PATCH iwl-next v8 3/9] idpf: move queue resources to idpf_q_vec_rsrc structure Joshua Hay
2025-10-15  7:22   ` Paul Menzel [this message]
2025-10-16 23:03     ` [Intel-wired-lan] [PATCH " Hay, Joshua A
2025-10-13 23:13 ` [Intel-wired-lan][PATCH iwl-next v8 4/9] idpf: reshuffle idpf_vport struct members to avoid holes Joshua Hay
2025-10-13 23:13 ` [Intel-wired-lan][PATCH iwl-next v8 5/9] idpf: add rss_data field to RSS function parameters Joshua Hay
2025-10-13 23:13 ` [Intel-wired-lan][PATCH iwl-next v8 6/9] idpf: remove vport pointer from queue sets Joshua Hay
2025-10-14  7:49   ` [Intel-wired-lan] [PATCH " Loktionov, Aleksandr
2025-10-13 23:13 ` [Intel-wired-lan][PATCH iwl-next v8 7/9] idpf: generalize send virtchnl message API Joshua Hay
2025-10-14  7:50   ` [Intel-wired-lan] [PATCH " Loktionov, Aleksandr
2025-10-13 23:13 ` [Intel-wired-lan][PATCH iwl-next v8 8/9] idpf: avoid calling get_rx_ptypes for each vport Joshua Hay
2025-10-14  7:50   ` [Intel-wired-lan] [PATCH " Loktionov, Aleksandr
2025-10-13 23:13 ` [Intel-wired-lan][PATCH iwl-next v8 9/9] idpf: generalize mailbox API Joshua Hay
2025-10-14  7:51   ` [Intel-wired-lan] [PATCH " Loktionov, Aleksandr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a49a045c-b01a-48d2-a02c-23540f799f8a@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=joshua.a.hay@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).