From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] tls: Avoid -Wflex-array-member-not-at-end warning
Date: Tue, 23 Sep 2025 22:53:03 +0200 [thread overview]
Message-ID: <a4b598a1-3ad6-4e42-9f48-21db966f0a34@embeddedor.com> (raw)
In-Reply-To: <aNMCznixxL2veGxK@krikkit>
>>
>> If this (flex array) is not going to be needed in the future, I'm
>> happy to remove it. :)
>
> I don't see what we'd use it for, aead_request.__ctx contains private
> data from the crypto code (all accesses seem to be through
> aead_request_ctx defined in include/crypto/internal/aead.h, see also
> the kdoc: "Start of private context data").
> And we haven't seen the author of a42055e8d2c3 in a while, so we can't
> ask about the intention behind this field.
>
> So IMO, tls_rec.aead_req_ctx can simply go away. Would you send the
> patch?
>
Done: https://lore.kernel.org/linux-hardening/aNMG1lyXw4XEAVaE@kspp/
Thank you for the feedback. :)
-Gustavo
prev parent reply other threads:[~2025-09-23 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 14:39 [PATCH][next] tls: Avoid -Wflex-array-member-not-at-end warning Gustavo A. R. Silva
2025-09-22 15:21 ` Sabrina Dubroca
2025-09-23 9:37 ` Gustavo A. R. Silva
2025-09-23 20:27 ` Sabrina Dubroca
2025-09-23 20:53 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4b598a1-3ad6-4e42-9f48-21db966f0a34@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).