From: Paolo Abeni <pabeni@redhat.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, horms@kernel.org, john.fastabend@gmail.com,
jiri@resnulli.us, zdi-disclosures@trendmicro.com,
sh.kalluri129@gmail.com, victor@mojatatu.com,
security@kernel.org, stable@vger.kernel.org,
Santosh Kalluri <santosh.kalluri129@gmail.com>
Subject: Re: [PATCH net 1/1] net/sched: cls_route: fix fastmap use-after-free on filter
Date: Tue, 28 Jul 2026 16:03:27 +0200 [thread overview]
Message-ID: <a4bda84e-3041-49b7-8863-e09862b2739e@redhat.com> (raw)
In-Reply-To: <CAM0EoMkRMOBmrGW3fAcxxhTxcLaP44zr4m5Ds8G2VFT1CissNA@mail.gmail.com>
On 7/28/26 3:12 PM, Jamal Hadi Salim wrote:
> On Tue, Jul 28, 2026 at 9:05 AM Paolo Abeni <pabeni@redhat.com> wrote:
>> On 7/28/26 2:37 PM, Jamal Hadi Salim wrote:
>>> On Tue, Jul 28, 2026 at 6:34 AM Paolo Abeni <pabeni@redhat.com> wrote:
>>>> Since there is already a
>>>> synchronization point for both reader and write while acquiring the
>>>> fastmap_lock, I'm wondering if something alike the following could work ?!?
>>>> (completely untested!!!):
>>>
>>> Your approach has some holes, example misses the most dangerous part -
>>> destroy(), etc
>>> I will mull over it and see if it can be fixed to handle all the
>>> issues. I think it's possible i just need to put time to
>>> validate/test.
>> I would appreciate that, thanks!
>
> See attached. Untested (compiles) - addresses my destroy() concern
> eaerlier _i think_ (unless something pops up in testing)
FWIW, the changes LGTM, thanks!
Paolo
prev parent reply other threads:[~2026-07-28 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 10:52 [PATCH net 1/1] net/sched: cls_route: fix fastmap use-after-free on filter Jamal Hadi Salim
2026-07-28 10:34 ` Paolo Abeni
2026-07-28 12:37 ` Jamal Hadi Salim
2026-07-28 13:05 ` Paolo Abeni
2026-07-28 13:12 ` Jamal Hadi Salim
2026-07-28 14:03 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4bda84e-3041-49b7-8863-e09862b2739e@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh.kalluri129@gmail.com \
--cc=security@kernel.org \
--cc=sh.kalluri129@gmail.com \
--cc=stable@vger.kernel.org \
--cc=victor@mojatatu.com \
--cc=zdi-disclosures@trendmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox