From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C881434F483 for ; Mon, 25 May 2026 16:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779725967; cv=none; b=a0bjWbr2zwQ5Ql4uoy1XT8ld+xhYkmg/qsTlStAnmykXHe+rwcUt0cVtKW08KwnFfs2hf/VpGH5fFGtfNqWnt3o4KbMwsjCr1Nrk5jbO3UqWJ0N3eK7mdN8FgOq77EAkK6aqaxGk7lyFvTJYsCsY80+p8Qt+JYYEZ2RXiLIiYQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779725967; c=relaxed/simple; bh=6ATTepTt/W1eTfJKlZcOEC7miXlLa4M2ScAL84EJqWk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NYuLStkIjEFCKhK8F36TcVAe3D+WK8KIGco/cVsB8AvSGfhUURYfiaDqtvYw9U4yGoZMLzFVkDpNNmfR5WoOtQT5hvNT7A6nzFFmMuPXA9J1Oty22T3KLyrBW1LA/slLkG9Pj3rCMpSjgJzZ7kxYv/2Xzr4da0kcFM1xJOxyHes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=dr4TZWgD; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="dr4TZWgD" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48a3e9862f0so51631185e9.1 for ; Mon, 25 May 2026 09:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779725963; x=1780330763; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6YA+/JJXQ9abERc/NViF0XyaL5qdJ2pUb4chRkVwshY=; b=dr4TZWgD1Esm3Qat2phkFsMogL1QSisy0KS5zRNj7QLd+O/GTWfZKF/uEdi+t9nmcR dNii4QQxToJf+zI9chidglTAOXLiVdJ387YJpWnu4O63RZWZpdft6OjU//0zfSVBO/Yy aLoJ+GdqYyIcf1QZ3S/llKFAOlJ84UyYM98oHjPHgYY3F7FL0OrljqOzg8++8jmqQw7A O5n5KKQspBxCRl24VEYndxfcbPND9j7SmWztWHYdSuVM/njdzkK1jbGeu/q+wYu+k1tw 8TTcdzkzuBj6AUmwdDxqdavz+slVMsWbwdX+qKe1b1YYNz7v1oMCb8aIIpb7FBEk2qd1 WQkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779725963; x=1780330763; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6YA+/JJXQ9abERc/NViF0XyaL5qdJ2pUb4chRkVwshY=; b=rmulw2JdQ/xhRWtA1RRL1y+pW2tQW9wLG1UR1hxZBF9ch+WZ3NCncpkBtBJY1RXuAo 2JQf0Bqctez+aUgxtnEHS/W7O5rScNOGPB006W/iFKwAfq5c1Ho00B3EVKc9ed+bRsKu 5qdgo3c8FQa8GsuRiSj0ujAJZMwPkd10VDJJOkewWHeoET5UNMxEMKl4lCd+g6FirXtF PdVpJ9dgwGAqjAhpe+tvTdY1Ox9xHKRaEByauTL7XJaCrGPQ11BMM6bX/Gp3vAcbhHGi p/gSmLtbAbWGr4tgW5Zg+4QcnhPe0EikD0J54qCv5vD42oyyz0rN0Ds0Rxtoyca6VI19 s67Q== X-Forwarded-Encrypted: i=1; AFNElJ8GXfloTQ0KHj9YCE2CeAp5i98HLsGKS94afHo9z87yfWjIm0QUU2l9pDZkQOLMb44mbWBn7lk=@vger.kernel.org X-Gm-Message-State: AOJu0YzwVoHnYOdgJ5cEmycNKgel2a3Mg8/PTx6CG9DVfnJf1lBGQ4Rj ejE/v775i2S/x3xjiJm4lWrv4OX0HAVNId1u0ZHNEvl7dPn8CREsmCVhepuu1faseYM= X-Gm-Gg: Acq92OG+sVnv4MZuNMRNbCtla8Afm5y3fGmUvk+PajQqhCt9W0igXXyUIitFxPl0B0X Lke2twXX8yOpXKGI7ZimYoErTXfEgBhDAbQmoCqGIAp+rX2Gn168KHzWIInTRDwzS4zemLwBxKI y6GrWivLBv9F2dcmtMgKj5dPhK1sDNmhRVyAgbV5eUryZ/2K14+IjYMozWQYXzSQSI01phcvlZu XAx8QqnFhqbLNskCiBMkvYwMl3m6NHS0F+4oxxp9t/Mlg0Xi7B6218gNpq2vyTtoj9ZeQ2+6Iul /XTAG/jNMjwg5BPjq3BD+u615E2g00GY/zlyOH5luqc//gRTJ2aAdgr0QeDve1eMfb3d7HRaTW6 1hy5D9kEkUKE4M6m9T/elrOcytxwCMaPdxdxrwCFP6IU6KH6P6B1K1xJ5u3UJTPZwMhKdaNcBv+ pL1wb9foHXBaSOhCdpu6ocozRIDuY3Mb5cEvpGVhWoKXGXBnOJWoJvAka6QCDXtVE6be4KM4mAx ATR4NGdsyDODraGGkBhuRVdX2YhtJTULAsm4Tdw7J2yFIFNLlmzHx/6IjU+9Agr8pNRzA== X-Received: by 2002:a05:600c:3b07:b0:490:f7c:b19 with SMTP id 5b1f17b1804b1-490420f67f5mr197977845e9.0.1779725963153; Mon, 25 May 2026 09:19:23 -0700 (PDT) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49059cc9a91sm48939425e9.1.2026.05.25.09.19.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 09:19:22 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 18:19:19 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] moduleparam: Add seq_buf-based .get callback alongside .get_str To: Kees Cook Cc: Luis Chamberlain , Pengpeng Hou , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andy Shevchenko , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-6-kees@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260521133326.2465264-6-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/21/26 3:33 PM, Kees Cook wrote: > Add a new struct kernel_param_ops::get callback whose signature > takes a struct seq_buf instead of a raw char buffer: > > int (*get)(struct seq_buf *sb, const struct kernel_param *kp); > > The previously-legacy .get field is now .get_str (char *buffer); > .get is the new seq_buf-aware form. param_attr_show() prefers .get > when set, otherwise falls back to .get_str. WARN_ON_ONCE() if both > are set. Return contract for .get: > > < 0 : errno propagated to userspace; seq_buf contents discarded > = 0 : success; length derived from seq_buf_used() > > 0 : forbidden; the dispatcher WARN_ON_ONCE()s and treats as 0 > > The default policy on seq_buf_has_overflowed() is silent truncation, > matching scnprintf()/sysfs_emit() behaviour. Callbacks that want a > specific overflow errno can check seq_buf_has_overflowed() and > return their preferred error. > > No callbacks use .get yet; the legacy path is still the only one in use > after this commit. A subsequent commit teaches DEFINE_KERNEL_PARAM_OPS > to route initializers by type. > > Signed-off-by: Kees Cook Reviewed-by: Petr Pavlu -- Petr