From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: iproute2-4.16.0 no longer accepts routes via fe80::1 Date: Thu, 12 Apr 2018 22:39:11 -0600 Message-ID: References: <53f39aca-b0ac-79a4-3427-175598b17037@gentoo.org> <9d8beae3-ff87-6e89-c4ac-941e3c890d71@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: serhe.popovych@gmail.com To: Thomas Deutschmann , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f53.google.com ([74.125.83.53]:43107 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbeDMEjO (ORCPT ); Fri, 13 Apr 2018 00:39:14 -0400 Received: by mail-pg0-f53.google.com with SMTP id f132so237747pgc.10 for ; Thu, 12 Apr 2018 21:39:14 -0700 (PDT) In-Reply-To: <9d8beae3-ff87-6e89-c4ac-941e3c890d71@gentoo.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/12/18 6:41 AM, Thomas Deutschmann wrote: > Hi, > > well, it isn't just "fe80::1", it is any IPv6 address which > will be rejected if not called with "-6". I run bisect: > >> git bisect start >> # good: [50b8a842e8c098cddb213f5b3076526df88826e8] v4.15.0 >> git bisect good 50b8a842e8c098cddb213f5b3076526df88826e8 >> # bad: [4b6c4177ee66421770f0bbcc765c29135e44d921] v4.16.0 >> git bisect bad 4b6c4177ee66421770f0bbcc765c29135e44d921 >> # bad: [5f4892e2c8d4fb22118713e0c83290b352fe0e34] rdma: Make visible the number of arguments >> git bisect bad 5f4892e2c8d4fb22118713e0c83290b352fe0e34 >> # good: [8c75f69411bc8c3affe5d173afcf981d15f5da15] Merge branch 'master' into net-next >> git bisect good 8c75f69411bc8c3affe5d173afcf981d15f5da15 >> # bad: [27c523e209ab956ff269afec68c6e744e7f5edb6] utils: Introduce get_addr_rta() and inet_addr_match_rta() >> git bisect bad 27c523e209ab956ff269afec68c6e744e7f5edb6 >> # bad: [d0bcedd549566a87354aa804df3be6be80681ee9] tc: introduce tc_qdisc_block_exists helper >> git bisect bad d0bcedd549566a87354aa804df3be6be80681ee9 >> # bad: [6c4b672738acf680ee98c10e79a52a8dede5f9a6] iplink_geneve: Get rid of inet_get_addr() >> git bisect bad 6c4b672738acf680ee98c10e79a52a8dede5f9a6 >> # bad: [93fa12418dc6f5943692250244be303bb162175b] utils: Always specify family and ->bytelen in get_prefix_1() >> git bisect bad 93fa12418dc6f5943692250244be303bb162175b >> # good: [f2522007d8fee924cb098b4afc8af16f2b25829f] utils: Always specify family for address in get_addr_1() >> git bisect good f2522007d8fee924cb098b4afc8af16f2b25829f >> # first bad commit: [93fa12418dc6f5943692250244be303bb162175b] utils: Always specify family and ->bytelen in get_prefix_1() > >> From 93fa12418dc6f5943692250244be303bb162175b Mon Sep 17 00:00:00 2001 >> From: Serhey Popovych >> Date: Thu, 18 Jan 2018 20:13:43 +0200 >> Subject: utils: Always specify family and ->bytelen in get_prefix_1() >> >> Handle default/all/any special case in get_addr_1() to setup >> ->family and ->bytelen correctly. >> >> Make get_addr_1() return ->bitlen == -2 instead of -1 to >> distinguish default/all/any special case from the rest: >> it is safe because all callers check ->bitlen < 0, not >> explicit value -1. >> >> Reduce intendation by one level and get rid of goto/label >> to make code more readable. >> >> Signed-off-by: Serhey Popovych >> Signed-off-by: David Ahern > > https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=93fa12418dc6f5943692250244be303bb162175b > > So was this an intended behavior change? I.e. this will require > updates for various user space tools/network configuration scripts > which are relying on ip utilities feature to auto-detect inet family > which was "supported" (at least working) until 4.16.0... > > Not intentional. Serhey please take a look