From: Eric Van Hensbergen <ericvh@gmail.com>
To: Abhishek Kulkarni <adkulkar@umail.iu.edu>
Cc: linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH] [net/9p]: default 9p transport module fix
Date: Tue, 14 Jul 2009 13:29:19 -0500 [thread overview]
Message-ID: <a4e6962a0907141129w23654edbp1ea309b19bf0b546@mail.gmail.com> (raw)
In-Reply-To: <1247492991-26009-2-git-send-email-adkulkar@umail.iu.edu>
applied v9fs-devel
On Mon, Jul 13, 2009 at 8:49 AM, Abhishek Kulkarni<adkulkar@umail.iu.edu> wrote:
> The default 9p transport module is not chosen unless an option parameter (any)
> is passed to mount, which thus returns a ENOPROTOSUPPORT. This fix moves the
> check out of parse_opts into p9_client_create.
>
> Signed-off-by: Abhishek Kulkarni <adkulkar@umail.iu.edu>
> ---
> :100644 100644 cc25e63... 787ccdd... M net/9p/client.c
> net/9p/client.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/9p/client.c b/net/9p/client.c
> index cc25e63..787ccdd 100644
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -117,9 +117,6 @@ static int parse_opts(char *opts, struct p9_client *clnt)
> }
> }
>
> - if (!clnt->trans_mod)
> - clnt->trans_mod = v9fs_get_default_trans();
> -
> kfree(options);
> return ret;
> }
> @@ -689,6 +686,9 @@ struct p9_client *p9_client_create(const char *dev_name, char *options)
> if (err < 0)
> goto error;
>
> + if (!clnt->trans_mod)
> + clnt->trans_mod = v9fs_get_default_trans();
> +
> if (clnt->trans_mod == NULL) {
> err = -EPROTONOSUPPORT;
> P9_DPRINTK(P9_DEBUG_ERROR,
> --
> 1.6.0.4
>
>
next prev parent reply other threads:[~2009-07-14 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 13:49 [PATCH] [net/9p] Possible regression in p9_client_stat Abhishek Kulkarni
2009-07-13 13:49 ` [PATCH] [net/9p]: default 9p transport module fix Abhishek Kulkarni
2009-07-14 18:29 ` Eric Van Hensbergen [this message]
2009-07-14 18:29 ` [PATCH] [net/9p] Possible regression in p9_client_stat Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e6962a0907141129w23654edbp1ea309b19bf0b546@mail.gmail.com \
--to=ericvh@gmail.com \
--cc=adkulkar@umail.iu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox