From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: Nnamdi Onyeyiri <nnamdio@gmail.com>
Cc: bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
horms@kernel.org, jakub@cloudflare.com, john.fastabend@gmail.com,
kuba@kernel.org, kuniyu@google.com, ncardwell@google.com,
netdev@vger.kernel.org, pabeni@redhat.com,
sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH v4 0/2] bpf, sockmap: handle spurious tcp_msg_wait_data() wakeup
Date: Thu, 16 Jul 2026 18:48:30 +0800 [thread overview]
Message-ID: <a4f21915-cccc-4f46-a3d1-0a9a825b47e3@linux.dev> (raw)
In-Reply-To: <aliwTlOayzvvlN10@localhost.localdomain>
On 7/16/26 6:24 PM, Nnamdi Onyeyiri wrote:
> On Thu, Jul 16, 2026 at 09:30:30AM +0800, Jiayuan Chen wrote:
>> Please do not send a patch by replying to an old thread.
>>
>> ...
>>
>> Please use a commit subject like "selftests/bpf: add selftest xxx" for the
>> selftest patch.
>>
> Sorry, I'll resubmit with these changes.
>
>> Please use existing test frameworks such as sockmap_basic.c or
>> sockmap_strp.c.
>>
> Just to clarify, do you mean I should add the new tests to one of these
> existing files? Or that I should add a new file, but write the test in the
> same way as sockmap_basic.c implements them?
>
> Thanks!
Using existing files is enough I guess.
I didn't read your selftest files fully, but I don't think a selftest
with 299+ lines is a good idea for reproducing a single problem.
I think you should try to shorten it to a reasonable size, e.g., by
reusing helpers.
next prev parent reply other threads:[~2026-07-16 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 18:43 [BUG] bpf, sockmap: spurious wakeup by tcp_msg_wait_data() causing unexpected EAGAIN in recvfrom() Nnamdi Onyeyiri
[not found] ` <20260709185526.E4DAB1F000E9@smtp.kernel.org>
2026-07-10 20:17 ` Nnamdi Onyeyiri
2026-07-13 4:14 ` Jiayuan Chen
2026-07-14 18:19 ` John Fastabend
2026-07-14 20:39 ` [PATCH v3 0/2] bpf, sockmap: handle spurious tcp_msg_wait_data() wakeup Nnamdi Onyeyiri
2026-07-14 20:39 ` [PATCH v3 1/2] " Nnamdi Onyeyiri
2026-07-14 20:39 ` [PATCH v3 2/2] " Nnamdi Onyeyiri
2026-07-15 21:35 ` [PATCH v4 0/2] " Nnamdi Onyeyiri
2026-07-15 21:35 ` [PATCH v4 1/2] " Nnamdi Onyeyiri
2026-07-15 21:35 ` [PATCH v4 2/2] " Nnamdi Onyeyiri
2026-07-16 1:30 ` [PATCH v4 0/2] " Jiayuan Chen
2026-07-16 10:24 ` Nnamdi Onyeyiri
2026-07-16 10:48 ` Jiayuan Chen [this message]
2026-07-14 18:16 ` [BUG] bpf, sockmap: spurious wakeup by tcp_msg_wait_data() causing unexpected EAGAIN in recvfrom() John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4f21915-cccc-4f46-a3d1-0a9a825b47e3@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=nnamdio@gmail.com \
--cc=pabeni@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox