From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [net-next 07/13] ixgbe: Fix crash with VFs and flow director on interface flap Date: Thu, 4 Oct 2018 12:12:36 +0300 Message-ID: References: <20181003202511.29684-1-jeffrey.t.kirsher@intel.com> <20181003202511.29684-8-jeffrey.t.kirsher@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Radoslaw Tyl , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com To: Jeff Kirsher , davem@davemloft.net Return-path: Received: from mail-lj1-f196.google.com ([209.85.208.196]:46766 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726998AbeJDQE7 (ORCPT ); Thu, 4 Oct 2018 12:04:59 -0400 Received: by mail-lj1-f196.google.com with SMTP id 203-v6so7654908ljj.13 for ; Thu, 04 Oct 2018 02:12:39 -0700 (PDT) In-Reply-To: <20181003202511.29684-8-jeffrey.t.kirsher@intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello! On 10/3/2018 11:25 PM, Jeff Kirsher wrote: > From: Radoslaw Tyl > > This patch fix crash when we have restore flow director filters after reset Fixes. Restored? > adapter. In ixgbe_fdir_filter_restore() filter->action is outside of the > rx_ring array, as it has a VF identifier in the upper 32 bits. > > Signed-off-by: Radoslaw Tyl > Tested-by: Andrew Bowers > Signed-off-by: Jeff Kirsher > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > index ddc22557155b..2928ce7653eb 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c [...] > @@ -5187,12 +5188,17 @@ static void ixgbe_fdir_filter_restore(struct ixgbe_adapter *adapter) > > hlist_for_each_entry_safe(filter, node2, > &adapter->fdir_filter_list, fdir_node) { > + action = filter->action; > + if (action != IXGBE_FDIR_DROP_QUEUE && action != 0) > + action = > + (action >> ETHTOOL_RX_FLOW_SPEC_RING_VF_OFF) - 1; Could you indent with extra tab here? [...] MBR, Sergei