From: Florian Fainelli <f.fainelli@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>
Cc: netdev@vger.kernel.org, DENG Qingfang <dqfext@gmail.com>,
Mauri Sandberg <sandberg@mailfence.com>
Subject: Re: [net-next PATCH 4/5 v2] net: dsa: rtl8366: VLAN 0 as disable tagging
Date: Wed, 17 Jun 2020 20:23:58 -0700 [thread overview]
Message-ID: <a575b511-fb9c-48c3-211b-0da5001b9e0c@gmail.com> (raw)
In-Reply-To: <20200617083132.1847234-4-linus.walleij@linaro.org>
On 6/17/2020 1:31 AM, Linus Walleij wrote:
> The code in net/8021q/vlan.c, vlan_device_event() sets
> VLAN 0 for a VLAN-capable ethernet device when it
> comes up.
>
> Since the RTL8366 DSA switches must have a VLAN and
> PVID set up for any packets to come through we have
> already set up default VLAN for each port as part of
> bringing the switch online.
>
> Make sure that setting VLAN 0 has the same effect
> and does not try to actually tell the hardware to use
> VLAN 0 on the port because that will not work.
Why, you are not really describing what happens if VID = 0 is programmed?
It also sounds like you should be setting
configure_vlan_while_not_filtering if you need the switch to be
configured with VLAN awareness no matter whether there is a bridge
configured or not.
--
Florian
next prev parent reply other threads:[~2020-06-18 3:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 8:31 [net-next PATCH 1/5 v2] net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag Linus Walleij
2020-06-17 8:31 ` [net-next PATCH 2/5 v2] net: dsa: rtl8366rb: Support the CPU DSA tag Linus Walleij
2020-06-18 1:27 ` Andrew Lunn
2020-06-17 8:31 ` [net-next PATCH 3/5 v2] net: dsa: rtl8366: Split out default VLAN config Linus Walleij
2020-06-18 1:29 ` Andrew Lunn
2020-06-17 8:31 ` [net-next PATCH 4/5 v2] net: dsa: rtl8366: VLAN 0 as disable tagging Linus Walleij
2020-06-18 1:31 ` Andrew Lunn
2020-06-18 3:23 ` Florian Fainelli [this message]
2020-07-05 23:04 ` Linus Walleij
2020-06-17 8:31 ` [net-next PATCH 5/5 v2] net: dsa: rtl8366: Use top VLANs for default Linus Walleij
2020-06-18 1:42 ` Andrew Lunn
2020-06-18 1:25 ` [net-next PATCH 1/5 v2] net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a575b511-fb9c-48c3-211b-0da5001b9e0c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=dqfext@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=sandberg@mailfence.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).