From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EAC5C433DF for ; Thu, 18 Jun 2020 03:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54C1A212CC for ; Thu, 18 Jun 2020 03:24:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u5GCsV6T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726976AbgFRDYG (ORCPT ); Wed, 17 Jun 2020 23:24:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726893AbgFRDYE (ORCPT ); Wed, 17 Jun 2020 23:24:04 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58306C06174E for ; Wed, 17 Jun 2020 20:24:04 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id l12so4809141ejn.10 for ; Wed, 17 Jun 2020 20:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5M/gH2V4+b8PALmvtckyWrGcRGiNDonnV7fIcVwIdEA=; b=u5GCsV6TccmVXAm/fbM1Lee4vn+yA/l9MDdtH8DiR4v0Btlzz046v++MkIVTo2u5CK qp0R1BKDuEfWxoj3YLc6Fsk6v9ETxKGEcAikplZQatDmNq/OZ1L/viormDPqDuext0MC tMBKP5Iz48x3QZnT+0iIgq3MHq4bRlaa6kKA+tbtUd0WPbDgtb4iyAk05j7l3PE4RaW8 RPGkkhw47KIQeT2o7g4vnWYSab/EIlI8smv4N9Hu6e+RkOFLjfozvuy1aQtoq4qVhoQ6 YsL194+vg0uLHSfRyldikk61G70rxDSO+AjLNP0MW0J124TXiZVxqOTghHsOlr1WUTJN rP5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5M/gH2V4+b8PALmvtckyWrGcRGiNDonnV7fIcVwIdEA=; b=mM5qqqoUkC4D4IJNgfMV+Pp9JdP7rC/h1a8hn/nx7lw+/YrvnlO/FJIKzgYBHF68qo RifpwKd6H/LtUhrKvKtLkOviV83trhAj9R1lQwvWpJE97s8cJ580tc88eO+HNSN+NZbN CzHO7nPB9ADoWZ1hzZSKKVCjoDMctOe282vK0OvefaiXRlP2YmlqG53I0+D4ZwnzHYiG 3fPTXx5neE74UEnEsDx57KDgifTQMEi5f0GegnsUS29P1zNdaRVPnCc+ECaT9wBE8fNT 8jgjOc6H7FP+rnTZ+6h4URtbsUlkPP7LwsUiiWmOda/pE1PXr1Lahmh9EKfwzVKYplFX SiSw== X-Gm-Message-State: AOAM532HBzTyrrBwqEDSOsP6W6sdMtCO9vY6N72ORiI0e7mHdskKe4pm bUwX+aqoQ8vijalkHIcpKdg= X-Google-Smtp-Source: ABdhPJzo6ADMPTkiL/mTjRmTmn65XJLbyeCEv/NM1Aj7zs9UT+5Dk4Ae9eBmKrdVqgD1SG3BOzwDuQ== X-Received: by 2002:a17:906:95d6:: with SMTP id n22mr2114953ejy.138.1592450642957; Wed, 17 Jun 2020 20:24:02 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id u13sm1307861ejf.60.2020.06.17.20.24.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 20:24:02 -0700 (PDT) Subject: Re: [net-next PATCH 4/5 v2] net: dsa: rtl8366: VLAN 0 as disable tagging To: Linus Walleij , Andrew Lunn , Vivien Didelot Cc: netdev@vger.kernel.org, DENG Qingfang , Mauri Sandberg References: <20200617083132.1847234-1-linus.walleij@linaro.org> <20200617083132.1847234-4-linus.walleij@linaro.org> From: Florian Fainelli Message-ID: Date: Wed, 17 Jun 2020 20:23:58 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200617083132.1847234-4-linus.walleij@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/17/2020 1:31 AM, Linus Walleij wrote: > The code in net/8021q/vlan.c, vlan_device_event() sets > VLAN 0 for a VLAN-capable ethernet device when it > comes up. > > Since the RTL8366 DSA switches must have a VLAN and > PVID set up for any packets to come through we have > already set up default VLAN for each port as part of > bringing the switch online. > > Make sure that setting VLAN 0 has the same effect > and does not try to actually tell the hardware to use > VLAN 0 on the port because that will not work. Why, you are not really describing what happens if VID = 0 is programmed? It also sounds like you should be setting configure_vlan_while_not_filtering if you need the switch to be configured with VLAN awareness no matter whether there is a bridge configured or not. -- Florian