From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C33C4360F for ; Fri, 5 Apr 2019 14:49:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B352B2175B for ; Fri, 5 Apr 2019 14:49:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nR5ds913" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730565AbfDEOtR (ORCPT ); Fri, 5 Apr 2019 10:49:17 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39998 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbfDEOtR (ORCPT ); Fri, 5 Apr 2019 10:49:17 -0400 Received: by mail-pf1-f195.google.com with SMTP id c207so3408894pfc.7 for ; Fri, 05 Apr 2019 07:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tSzF+NNLlzAwQMVjahioI8Z7cg5JDUJVHXFUsWXccao=; b=nR5ds913CRmvaZDi835jyr+N7OlPPJgU1eDarK+xFxw/TI2xaBQas/Jsjuf3emOy5J qS0wCdBTo/SPZ6IFZNPFyn89OQcpIACtzc+CQmQjbSXFu5+DNWaX8n6RGeSUwYvqBbGq itmEyKv8yfjlpfio+PjZBfbzBHiups3LC4BqJGv8FVqhxQ2cr8mP3ZnSGDPndTqMD4FZ 1mCxqQknmY/0B+S/TWm4jWouKUcxHAPzdnbPUW3yb5GGbmeYU2KGY08sEIRTlloQGmQj 5+Do88lJ7x60yugYoKpWIE9fVSKXfbdXv8zCqZOMI9i/D+zIFdzTeZq8zVS6zkTU24AF 5y7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tSzF+NNLlzAwQMVjahioI8Z7cg5JDUJVHXFUsWXccao=; b=SRxn/Vcpe506qjOAMj9ayj/JyDO6jxfPptzLBwzM5U7Fb9kLLOXj2ECm8gB7pwqXXj QVSITakpybM5eyD9pYLa9EQbncm6s+PJP61/8Gh/3qvkg0/pO8uf3yr9cAHlbqS/55FH QUCovI/ZCCnxpaSbeJMtVoPPgqhFldZiZ94qauY7WWxzLE7ZbgXv9SeYVKgVDTJpCf/7 pHyzkFRpPnI3/Vlvawj5e7Nbe+DRmiCcrbxOZmvuiacfJTtO4qi6XVCLLQumaWjVgDwZ 2x3g7SKR43p2tUbJ0gAYLvQ6OM3OKEHD2mD8JdQofW2fzxpuAz19tHV+/HhX2f5EvOmg Z1FA== X-Gm-Message-State: APjAAAVEi0qME//DGWtNWV/wk9VdHdDvytg7+Svodl1ek7p9wgQZH/JW 09nIRVRwXhFKs7WXjw+XXQ5/VQbh X-Google-Smtp-Source: APXvYqzkq54FnvsLSf+dkXGyggPcpLt/65KpPmdGB9ZrtWfRjg0LbAop3rc1eHI9y5b8zDWAKhQMmg== X-Received: by 2002:a62:474a:: with SMTP id u71mr12916251pfa.87.1554475756532; Fri, 05 Apr 2019 07:49:16 -0700 (PDT) Received: from [172.27.227.243] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id n17sm14145349pgk.81.2019.04.05.07.49.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 07:49:15 -0700 (PDT) Subject: Re: [PATCH net-next 01/18] ipv6: Add fib6_nh_init and release to stubs To: Ido Schimmel , David Ahern Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko References: <20190404175007.8150-1-dsahern@kernel.org> <20190404175007.8150-2-dsahern@kernel.org> <20190405124618.GA6739@splinter> From: David Ahern Message-ID: Date: Fri, 5 Apr 2019 08:49:14 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190405124618.GA6739@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/5/19 6:46 AM, Ido Schimmel wrote: > On Thu, Apr 04, 2019 at 10:49:50AM -0700, David Ahern wrote: >> From: David Ahern >> >> Signed-off-by: David Ahern > > Reviewed-by: Ido Schimmel > >> +static int eafnosupport_fib6_nh_init(struct net *net, struct fib6_nh *fib6_nh, >> + struct fib6_config *cfg, gfp_t gfp_flags, >> + struct netlink_ext_ack *extack) >> +{ >> + NL_SET_ERR_MSG(extack, "IPv6 support not enabled in kernel"); >> + return -EAFNOSUPPORT; >> +} >> + >> const struct ipv6_stub *ipv6_stub __read_mostly = &(struct ipv6_stub) { >> .ipv6_dst_lookup = eafnosupport_ipv6_dst_lookup, >> .ipv6_route_input = eafnosupport_ipv6_route_input, >> @@ -181,6 +189,7 @@ const struct ipv6_stub *ipv6_stub __read_mostly = &(struct ipv6_stub) { >> .fib6_lookup = eafnosupport_fib6_lookup, >> .fib6_multipath_select = eafnosupport_fib6_multipath_select, >> .ip6_mtu_from_fib6 = eafnosupport_ip6_mtu_from_fib6, >> + .fib6_nh_init = eafnosupport_fib6_nh_init, >> }; > > I thought this would explode in fib_check_nh_v6_gw() if IPv6 is not > enabled because fib6_nh_release() is NULL, but you actually check that > earlier in fib_gw_from_via(), so it's fine. The intent is that since fib6_nh_init fails fib6_nh_release should not be called hence a not-supported stub should not be needed. > > BTW, the error message in that case is "IPv6 support is not enabled in > this kernel", which is a bit different from what you have here. Might be > a good idea to be more consistent about it. > ah, patch 17. Yes, will make consistent.