From: Dragos Tatulea <dtatulea@nvidia.com>
To: Amery Hung <ameryhung@gmail.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
Christoph Paasch <cpaasch@openai.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, Gal Pressman <gal@nvidia.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH net-next V6 2/3] net/mlx5e: Avoid copying payload to the skb's linear part
Date: Thu, 14 May 2026 14:35:38 +0200 [thread overview]
Message-ID: <a5936aa0-6798-4f8f-a238-49ba590b0ca3@nvidia.com> (raw)
In-Reply-To: <CAMB2axMOWSsYGyuXOnCQUrpCTGJa_Yy5mKOxErX7N2x3BTLKbg@mail.gmail.com>
On 12.05.26 18:30, Amery Hung wrote:
>> That would work, but maybe with one less conditional:
>>
>> if (!len)
>> __pskb_pull_tail(skb, min(headlen, skb->data_len);
>> else if (len < ETH_HLEN)
>> __pskb_pull_tail(skb, min(ETH_LEN - len, skb->data_len));
>>
>> Tariq suggested to make sure that we have an xdp selftest for this.
>> Will take it as a follow-up after this series.
>>
>
> Sounds good. Make sense.
>
Holding off the patch for a bit. I was curious how bad it would be to
always pull at most ETH_HLEN (as in the else case) and not to read the
headlen anymore. So far results are encouraging. This would simplify
the logic.
Thanks,
Dragos
next prev parent reply other threads:[~2026-05-14 12:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 9:53 [PATCH net-next V6 0/3] net/mlx5: Avoid payload in skb's linear part for better GRO-processing Tariq Toukan
2026-05-07 9:53 ` [PATCH net-next V6 1/3] net/mlx5e: DMA-sync earlier in mlx5e_skb_from_cqe_mpwrq_nonlinear Tariq Toukan
2026-05-07 9:53 ` [PATCH net-next V6 2/3] net/mlx5e: Avoid copying payload to the skb's linear part Tariq Toukan
2026-05-07 13:53 ` Amery Hung
2026-05-07 15:49 ` Dragos Tatulea
2026-05-07 20:50 ` Amery Hung
2026-05-08 9:15 ` Dragos Tatulea
2026-05-08 17:44 ` Amery Hung
2026-05-08 18:42 ` Dragos Tatulea
2026-05-10 6:50 ` Dragos Tatulea
2026-05-11 23:08 ` Amery Hung
2026-05-12 15:33 ` Dragos Tatulea
2026-05-12 16:30 ` Amery Hung
2026-05-14 12:35 ` Dragos Tatulea [this message]
2026-05-08 12:43 ` David Laight
2026-05-08 13:30 ` Dragos Tatulea
2026-05-07 9:53 ` [PATCH net-next V6 3/3] net/mlx5e: Align header copy to cache line for Striding RQ non-linear Tariq Toukan
2026-05-07 19:58 ` [PATCH net-next V6 0/3] net/mlx5: Avoid payload in skb's linear part for better GRO-processing Christoph Paasch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5936aa0-6798-4f8f-a238-49ba590b0ca3@nvidia.com \
--to=dtatulea@nvidia.com \
--cc=ameryhung@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=cpaasch@openai.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox