From: Roger Quadros <rogerq@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
danishanwar@ti.com, srk@ti.com, linux-omap@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 6/9] net: ethernet: ti: cpsw_ale: add cpsw_ale_policer_set/clr_entry()
Date: Wed, 2 Apr 2025 15:37:25 +0300 [thread overview]
Message-ID: <a5a47ca2-a64a-409f-a143-637699e316c7@kernel.org> (raw)
In-Reply-To: <20250325072141.026b643d@kernel.org>
On 25/03/2025 16:21, Jakub Kicinski wrote:
> On Wed, 19 Mar 2025 15:38:32 +0200 Roger Quadros wrote:
>> +/* FIXME: VLAN ID based flow routing not yet working, Only PCP matching for now
>> + * u32 port_mask, unreg_mcast = 0;
>> + *
>> + * port_mask = BIT(cfg->port_id) | ALE_PORT_HOST;
>> + * if (!cfg->vid)
>> + * unreg_mcast = port_mask;
>> + * ale_idx = cpsw_ale_vlan_add_modify(ale, cfg->vid, port_mask,
>> + * unreg_mcast, port_mask, 0);
>> + * if (ale_idx < 0)
>> + * return -ENOENT;
>> + *
>> + * regmap_field_write(ale->fields[POL_OVLAN_INDEX], ale_idx);
>> + * regmap_field_write(ale->fields[POL_OVLAN_MEN], 1);
>> + */
>
> This commented out code is odd.
> Shouldn't you check if the user asked for ID match and return an error?
I think I'll drop the comment.
--
cheers,
-roger
next prev parent reply other threads:[~2025-04-02 12:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 13:38 [PATCH net-next 0/9] net: ethernet: ti: am65-cpsw: add network flow classification support Roger Quadros
2025-03-19 13:38 ` [PATCH net-next 1/9] net: ethernet: ti: cpsw_ale: Update Policer fields for more ALE size/ports Roger Quadros
2025-03-19 13:38 ` [PATCH net-next 2/9] net: ethernet: ti: cpsw_ale: return ALE index in cpsw_ale_add_vlan() Roger Quadros
2025-03-19 13:38 ` [PATCH net-next 3/9] net: ethernet: ti: cpsw_ale: return ALE index in cpsw_ale_vlan_add_modify() Roger Quadros
2025-03-19 13:38 ` [PATCH net-next 4/9] net: ethernet: ti: cpsw_ale: return ALE index in cpsw_ale_add_ucast() Roger Quadros
2025-03-19 13:38 ` [PATCH net-next 5/9] net: ethernet: ti: cpsw_ale: add cpsw_ale_policer_reset_entry() Roger Quadros
2025-03-19 13:38 ` [PATCH net-next 6/9] net: ethernet: ti: cpsw_ale: add cpsw_ale_policer_set/clr_entry() Roger Quadros
2025-03-25 14:21 ` Jakub Kicinski
2025-04-02 12:37 ` Roger Quadros [this message]
2025-03-25 14:22 ` Jakub Kicinski
2025-03-19 13:38 ` [PATCH net-next 7/9] net: ethernet: ti: cpsw_ale: add policer save restore for PM sleep Roger Quadros
2025-03-19 13:38 ` [PATCH net-next 8/9] net: ethernet: ti: am65-cpsw: add network flow classification support Roger Quadros
2025-03-25 14:24 ` Jakub Kicinski
2025-03-19 13:38 ` [PATCH net-next 9/9] net: ethernet: ti: am65-cpsw: remove cpsw_ale_classifier_setup_default() Roger Quadros
2025-03-25 14:19 ` [PATCH net-next 0/9] net: ethernet: ti: am65-cpsw: add network flow classification support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5a47ca2-a64a-409f-a143-637699e316c7@kernel.org \
--to=rogerq@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).