From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schmidt Subject: Re: [PATCH v4 net-next 08/19] inet: frags: use rhashtables for reassembly units Date: Mon, 16 Apr 2018 14:54:49 +0200 Message-ID: References: <20180331195900.183604-1-edumazet@google.com> <20180331195900.183604-9-edumazet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev , Eric Dumazet , Alexander Aring To: Eric Dumazet , "David S . Miller" Return-path: Received: from osg.samsung.com ([64.30.133.232]:53189 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbeDPMy4 (ORCPT ); Mon, 16 Apr 2018 08:54:56 -0400 In-Reply-To: <20180331195900.183604-9-edumazet@google.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello Eric. On 03/31/2018 09:58 PM, Eric Dumazet wrote: > Some applications still rely on IP fragmentation, and to be fair linux > reassembly unit is not working under any serious load. [...] > --- > Documentation/networking/ip-sysctl.txt | 7 +- > include/net/inet_frag.h | 81 +++--- > include/net/ipv6.h | 16 +- > net/ieee802154/6lowpan/6lowpan_i.h | 26 +- > net/ieee802154/6lowpan/reassembly.c | 93 +++---- > net/ipv4/inet_fragment.c | 354 +++++------------------- > net/ipv4/ip_fragment.c | 112 ++++---- > net/ipv6/netfilter/nf_conntrack_reasm.c | 51 +--- > net/ipv6/reassembly.c | 110 ++++---- > 9 files changed, 271 insertions(+), 579 deletions(-) > Just a heads up to let you know that this patch broke the 6LoWPAN fragmentation/reassembly for 802.15.4 Simply initiating a ssh session will fail. After a 1.5 days git bisect session it pointed me to this commit. :-) After reverting it (and some other patches of this series due to inter dependencies) it started working again. No further debugging on this from my side yet, as I just found it and wanted to let you know in case you have an idea what's going on. I will try to make some room this week to help with debugging and fixing. regards Stefan Schmidt