From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next 03/13] net: sched: extend Qdisc with rcu Date: Thu, 6 Sep 2018 01:30:19 -0700 Message-ID: References: <1536220742-25650-1-git-send-email-vladbu@mellanox.com> <1536220742-25650-4-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, stephen@networkplumber.org, ktkhai@virtuozzo.com, paulmck@linux.vnet.ibm.com, nicolas.dichtel@6wind.com, leon@kernel.org, gregkh@linuxfoundation.org, mark.rutland@arm.com, fw@strlen.de, dsahern@gmail.com, lucien.xin@gmail.com, jakub.kicinski@netronome.com, christian.brauner@ubuntu.com, jbenc@redhat.com To: Vlad Buslov , netdev@vger.kernel.org Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:34654 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727631AbeIFNEm (ORCPT ); Thu, 6 Sep 2018 09:04:42 -0400 Received: by mail-wm0-f68.google.com with SMTP id j25-v6so15958141wmc.1 for ; Thu, 06 Sep 2018 01:30:22 -0700 (PDT) In-Reply-To: <1536220742-25650-4-git-send-email-vladbu@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/06/2018 12:58 AM, Vlad Buslov wrote: ... > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h > index 18e22a5a6550..239c73f29471 100644 > --- a/include/net/sch_generic.h > +++ b/include/net/sch_generic.h > @@ -90,6 +90,7 @@ struct Qdisc { > struct gnet_stats_queue __percpu *cpu_qstats; > int padded; > refcount_t refcnt; > + struct rcu_head rcu; > > /* > * For performance sake on SMP, we put highly modified fields at the end Probably better to move this at the end of struct Qdisc, not risking unexpected performance regressions in fast path.