From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488B4C4320D for ; Tue, 24 Sep 2019 16:39:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F78420872 for ; Tue, 24 Sep 2019 16:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569343168; bh=31fULJRsplcQysMu3iE6XYHMLJOX8LT8PGFPRUwzB7k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=Mgmysey5U3SCRqlAlRvlY7fBYyFj45ZJt/tCP9nDa3P5mOL0yKYCBgtAk5scYV1+T xArygMq7d5uuIBvKPH3iusaigoF3ZaVF0iYllX6DCkpjmBGnxAd1/+cMWhEfhulftG OdQUzy9CEIdl8Qg/jJP3bjWfu6hpouCnrKi6uO3g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390916AbfIXQj1 (ORCPT ); Tue, 24 Sep 2019 12:39:27 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:43411 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727792AbfIXQj1 (ORCPT ); Tue, 24 Sep 2019 12:39:27 -0400 Received: by mail-io1-f65.google.com with SMTP id v2so5992399iob.10 for ; Tue, 24 Sep 2019 09:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aQXjcttbLiJ66376wUArCGw4+fMYjer27LHa16Xc6r0=; b=U7w52Z0Fp8BOUxTOn/qWC98gNV4cup4wa+YgUKx5VVMQVMnJj8wSE6W0dbRjCKKm2H pviOHtF2QyPwud9ic8nsDjDwD7azHH5eETtdUlmx56xv/AbX4fpGaO9UyjWZdYBui+yg uJO8cqDV6t+pjPvBHAnKgUEV8VxziirI1kPVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aQXjcttbLiJ66376wUArCGw4+fMYjer27LHa16Xc6r0=; b=G1vl1xg8scmvfpZRUz5FugXg7ZwQqkGoQN3wZUlxYJSTJ2FJx9IFJmna2nAudZ1Ws8 GB9LLkNUudSXdwRJrA5a4WwXE46PRhfX6VLCwBxqVqyx7jYYf0DGAH/cFpViUlS741Ff Kx27KvdzQbOifN7oESqvrnT7PL84A1JJUpFrvNuOnXAPQyjJbHjhqn9AEpBwXiTCjQz9 yLybpelG4klGdWlVdXHwR16Q7H94u+zvwLlMQ7PrYuIzGi/ZbJs4QwhNxx8m4zaI6wo3 d+tgaRCNgtj4Td8d2cuDrrYQBK7NJcrfIc0qqyeom4jhlb/EPwDlwe2ysB6YXPVnGPFe xkFg== X-Gm-Message-State: APjAAAX2i0hKtLnf3Q+/3bwFqQaQqKMnq3U/CIFzm4fM+DfAvi37ISPw /i2jWsqiTNgX6wID9hiay1vvsA== X-Google-Smtp-Source: APXvYqzBLrOYjDVzR8fRyI2p2F4LP7qEI6zo8Yubh6Ub7ZXmgn7T702iWitKfSKlU8c7GRrUZGZWYw== X-Received: by 2002:a6b:c895:: with SMTP id y143mr4301975iof.271.1569343164692; Tue, 24 Sep 2019 09:39:24 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id m5sm1755446ioh.69.2019.09.24.09.39.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Sep 2019 09:39:23 -0700 (PDT) Subject: Re: Linux 5.4 - bpf test build fails To: Cristian Marussi , Alexei Starovoitov , Daniel Borkmann Cc: "open list:KERNEL SELFTEST FRAMEWORK" , bpf , Networking , "David S. Miller" , Shuah Khan References: <742ecabe-45ce-cf6e-2540-25d6dc23c45f@linuxfoundation.org> <1d1bbc01-5cf4-72e6-76b3-754d23366c8f@arm.com> <34a9bd63-a251-0b4f-73b6-06b9bbf9d3fa@linuxfoundation.org> From: Shuah Khan Message-ID: Date: Tue, 24 Sep 2019 10:39:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <34a9bd63-a251-0b4f-73b6-06b9bbf9d3fa@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/24/19 10:03 AM, Shuah Khan wrote: > On 9/24/19 9:52 AM, Cristian Marussi wrote: >> Hi Shuah >> >> On 24/09/2019 16:26, Shuah Khan wrote: >>> Hi Alexei and Daniel, >>> >>> bpf test doesn't build on Linux 5.4 mainline. Do you know what's >>> happening here. >>> >>> >>> make -C tools/testing/selftests/bpf/ >> >> side question, since I'm writing arm64/ tests. >> >> my "build-testcases" following the KSFT docs are: >> >> make kselftest >> make TARGETS=arm64 kselftest >> make -C tools/testing/selftests/ >> make -C tools/testing/selftests/ INSTALL_PATH= install >> make TARGETS=arm64 -C tools/testing/selftests/ >> make TARGETS=arm64 -C tools/testing/selftests/ >> INSTALL_PATH= install >> ./kselftest_install.sh Cristian, That being said, I definitely want to see this list limited to a few options. One problem is that if somebody wants to do just a build, there is no option from the main makefile. I have sent support for that a few months ago and the patch didn't got lost it appears. I am working on resending those patches. The same is true for install. I sent in a patch for that a while back and I am going to resend. These will make it easier for users. I would really want to get to supporting only these options: These are supported now: make kselftest make TARGETS=arm64 kselftest (one or more targets) Replace the following: make -C tools/testing/selftests/ with make kselftes_build option from main makefile Replace this: make -C tools/testing/selftests/ INSTALL_PATH= install with make kselftest_install That way we can support all the use-cases from the main Makefile thanks, -- Shuah