From: Edward Cree <ecree.xilinx@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, michael.chan@broadcom.com,
saeedm@nvidia.com, leon@kernel.org, habetsm.xilinx@gmail.com,
f.fainelli@gmail.com, andrew@lunn.ch, mkubecek@suse.cz,
ariela@nvidia.com
Subject: Re: [PATCH net-next 5/6] sfc: ef10: implement ethtool::get_fec_stats
Date: Mon, 19 Apr 2021 13:39:21 +0100 [thread overview]
Message-ID: <a605fafb-a685-978c-8188-45eae96cfa04@gmail.com> (raw)
In-Reply-To: <20210414034454.1970967-6-kuba@kernel.org>
On 14/04/2021 04:44, Jakub Kicinski wrote:
> Report what appears to be the standard block counts:
> - 30.5.1.1.17 aFECCorrectedBlocks
> - 30.5.1.1.18 aFECUncorrectableBlocks
>
> Don't report the per-lane symbol counts, if those really
> count symbols they are not what the standard calls for
> (even if symbols seem like the most useful thing to count.)
>
> Fingers crossed that fec_corrected_errors is not in symbols.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
I'm trying to find out whether these count the right thing or not.
Some component documentation says that the per-lane _signal_ "asserts at
maximum once per FEC coding block". I haven't yet been able to track
down how the counters aggregate that, but it would seem to suggest that
they in fact count blocks and not symbols, and are just misnamed.
Investigation continues.
-ed
next prev parent reply other threads:[~2021-04-19 12:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 3:44 [PATCH net-next 0/6] ethtool: add standard FEC statistics Jakub Kicinski
2021-04-14 3:44 ` [PATCH net-next 1/6] ethtool: move ethtool_stats_init Jakub Kicinski
2021-04-14 3:44 ` [PATCH net-next 2/6] ethtool: fec_prepare_data() - jump to error handling Jakub Kicinski
2021-04-14 3:44 ` [PATCH net-next 3/6] ethtool: add FEC statistics Jakub Kicinski
2021-04-15 6:25 ` Saeed Mahameed
2021-04-15 15:21 ` Jakub Kicinski
2021-04-15 22:33 ` Saeed Mahameed
2021-04-14 3:44 ` [PATCH net-next 4/6] bnxt: implement ethtool::get_fec_stats Jakub Kicinski
2021-04-15 20:58 ` Michael Chan
2021-04-14 3:44 ` [PATCH net-next 5/6] sfc: ef10: " Jakub Kicinski
2021-04-19 12:39 ` Edward Cree [this message]
2021-04-14 3:44 ` [PATCH net-next 6/6] mlx5: " Jakub Kicinski
2021-04-15 6:37 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a605fafb-a685-978c-8188-45eae96cfa04@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrew@lunn.ch \
--cc=ariela@nvidia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).