From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>, Lukasz Majewski <lukma@denx.de>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
davem@davemloft.net, Andrew Lunn <andrew+netdev@lunn.ch>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description (fec,mtip-switch.yaml)
Date: Tue, 25 Mar 2025 16:11:00 +0100 [thread overview]
Message-ID: <a60c6ea2-628b-447d-bdc2-ebc7bd7d7400@kernel.org> (raw)
In-Reply-To: <2ccab52d-5ed1-4257-a8f1-328c76127ebe@lunn.ch>
On 25/03/2025 16:05, Andrew Lunn wrote:
>> + phy-reset-gpios:
>> + deprecated: true
>> + description:
>> + Should specify the gpio for phy reset.
>
> It seem odd that a new binding has deprecated properties. Maybe add a
> comment in the commit message as to why they are there. I assume this
> is because you are re-using part of the FEC code as is, and it
> implements them?
Re-using existing driver code should not be a reason to use deprecated
properties, because you can change that common driver parts to support
both: old FEC style and new MTIP-L2-FEC switch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-25 15:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 11:57 [PATCH 0/5] net: mtip: Add support for MTIP imx287 L2 switch driver Lukasz Majewski
2025-03-25 11:57 ` [PATCH 1/5] MAINTAINERS: Add myself as the MTIP L2 switch maintainer (IMX SoCs: imx287) Lukasz Majewski
2025-03-25 12:01 ` Krzysztof Kozlowski
2025-03-25 12:15 ` Lukasz Majewski
2025-03-25 11:57 ` [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description (fec,mtip-switch.yaml) Lukasz Majewski
2025-03-25 12:04 ` Krzysztof Kozlowski
2025-03-25 12:15 ` Lukasz Majewski
2025-03-25 12:24 ` Krzysztof Kozlowski
2025-03-25 12:39 ` Lukasz Majewski
2025-03-25 12:43 ` Krzysztof Kozlowski
2025-03-25 14:27 ` Lukasz Majewski
2025-03-25 13:25 ` Rob Herring (Arm)
2025-03-25 15:05 ` Andrew Lunn
2025-03-25 15:11 ` Krzysztof Kozlowski [this message]
2025-03-25 16:12 ` Lukasz Majewski
2025-03-26 13:43 ` Lukasz Majewski
2025-03-26 14:15 ` Krzysztof Kozlowski
2025-03-26 15:24 ` Andrew Lunn
2025-03-25 11:57 ` [PATCH 3/5] arm: dts: Adjust the 'reg' range for imx287 L2 switch description Lukasz Majewski
2025-03-25 12:04 ` Krzysztof Kozlowski
2025-03-25 12:19 ` Lukasz Majewski
2025-03-25 11:57 ` [PATCH 4/5] arm: dts: imx287: Provide description for MTIP L2 switch Lukasz Majewski
2025-03-25 15:14 ` Andrew Lunn
2025-03-25 16:16 ` Lukasz Majewski
2025-03-25 11:57 ` [PATCH 5/5] net: mtip: The L2 switch driver for imx287 Lukasz Majewski
2025-03-25 12:11 ` Krzysztof Kozlowski
2025-03-25 13:28 ` Lukasz Majewski
2025-03-25 14:36 ` Krzysztof Kozlowski
2025-03-25 15:34 ` Andrew Lunn
2025-03-25 16:38 ` Lukasz Majewski
2025-03-25 17:13 ` Krzysztof Kozlowski
2025-03-25 17:30 ` Lukasz Majewski
2025-03-25 14:51 ` [PATCH 0/5] net: mtip: Add support for MTIP imx287 L2 switch driver Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a60c6ea2-628b-447d-bdc2-ebc7bd7d7400@kernel.org \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).