From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kirill Tkhai <ktkhai@virtuozzo.com>
Subject: Re: [PATCH] net: Make synchronize_net() be expedited only when it's
 really need
Date: Tue, 23 Jan 2018 20:09:04 +0300
Message-ID: <a62606ed-df12-4406-3e22-5387809734b4@virtuozzo.com>
References: <151661402727.29441.3116565394148374460.stgit@localhost.localdomain>
 <1516641317.3478.8.camel@gmail.com>
 <537c27a9-e4e5-4145-75e5-daccb43ad9b3@virtuozzo.com>
 <CANn89iJ+-SqocFHgs7hvBaK_5OTkCf1jwsLuAU0DFvRv8e-shg@mail.gmail.com>
 <06844c66-d133-578d-cbac-b660aa71fc19@virtuozzo.com>
 <CANn89i+kT4ABn-PsDzVFrpUvEXwm=CFDTSDATnvkz41j-adVLA@mail.gmail.com>
 <b7903fb0-2d6d-97a9-492c-93057f28e405@virtuozzo.com>
 <CANn89iJ+DSrBu0djfn-JRmm1shWKnzjOhcGOPOFBScnWPXqKxA@mail.gmail.com>
 <97374a63-ad6a-c7b9-9739-70a1855fb8bb@virtuozzo.com>
 <CANn89iL=MGSUhjfR-WgCS2N3FE0CEPpUfKSUOCTpjT4dnL7M0w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
        netdev <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        David Ahern <dsahern@gmail.com>,
        Florian Westphal <fw@strlen.de>,
        Xin Long <lucien.xin@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        mschiffer@universe-factory.net, jakub.kicinski@netronome.com,
        Vladislav Yasevich <vyasevich@gmail.com>,
        Jiri Benc <jbenc@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-eopbgr60098.outbound.protection.outlook.com ([40.107.6.98]:48000
        "EHLO EUR01-DB5-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751402AbeAWRJM (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 23 Jan 2018 12:09:12 -0500
In-Reply-To: <CANn89iL=MGSUhjfR-WgCS2N3FE0CEPpUfKSUOCTpjT4dnL7M0w@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 23.01.2018 19:58, Eric Dumazet wrote:
>>
>> Your original patch did not provide any test results. Only the fact synchronize_rcu_expedited()
>> completes faster than plain synchronize_rcu(). But this is an obvious fact
>> just because of the design, and this is described even in the documentation.
>> Beleive me, I don't want to offend you this words, but it's strange you hadn't
>> gone the way you suggest me.
> 
> Well, I guess you missed the fine changelog.
> 
> Please carefully read it :
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=be3fc413da9eb17cce0991f214ab019d16c88c41

This is just what I said.

> And you' ll noticed I had an Ack from Paul E. McKenney, the RCU maintainer.
I won't ask you either you had the ACK before you sent the patch, because
the answer is obvious.

Anyway, this doesn't matter. I don't insist on the fix for this place.
If you're so negative on this question, we may leave everything as is,
and live with this ambiguous place several years more.

Kirill