From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3337C282C0 for ; Fri, 25 Jan 2019 19:39:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C521F218D0 for ; Fri, 25 Jan 2019 19:39:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mx+tv3BY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726335AbfAYTjx (ORCPT ); Fri, 25 Jan 2019 14:39:53 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:40309 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbfAYTjw (ORCPT ); Fri, 25 Jan 2019 14:39:52 -0500 Received: by mail-wr1-f68.google.com with SMTP id p4so11532093wrt.7 for ; Fri, 25 Jan 2019 11:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DtXuN17RCVplh/pybsPyLp5Ms7rmBzAup99/QfbXoww=; b=Mx+tv3BYCUmBMtxYJQFPTMwYSIvUzpAsLNHMxXyszK8zhx3MpJ8vSRLYXbD/hWZ2Sw GEi7cd+qV614k8Dnf2cJDtkftWcHiqL1KykKHmh5CtFd+exufvrw6O3ljwbu6SZSFHjP PHSUTOFTaoNCo3I3V6xwjzvtufMo0qcmqgb4VSt1TDxOctfwwp4mXpavLIf3h/CJaS7B 1UZyl58bAu4xVmxrKnoe3udEIXEG1b85/6OJVXWDRTcan/RH1cTT7uc0E2bmhl34Zp4W eoZVCtCPTO6I0ulFwSfqrQ4lreUQjMTeU4/jlGHqjcsHeACDTy+b92Mnd0aGUfnNTsNN 1v/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DtXuN17RCVplh/pybsPyLp5Ms7rmBzAup99/QfbXoww=; b=j02AI8Nr9dpDcWk9vT1jKWcYiYQl+C1EThwI1fKuKhjBM01vD9Rt23iAJJFZGnIlyA 56NGErUvnTRxQAjBgzf5dcjDaif1v9MjEpLnA3LPxoI4a/UnkA4XEg8DhY0yeEih2dOX dpL3SEODhaP7BDK5dV6RjU9GzjYOZtjY9gudbewzKvyprbn7MTcJCu3+wj+STNVD6hl5 Aflg3Whg6ySqcSgOpMwuPrDlv3e1brQXuc2JVMNygo3TYKZzxrFcE8NR73kFP48bXut6 GZvmv7NAlnP6nGwvgXFZByQZ+holr5PloGq0TQwgip+QAEhP+I1dcuXIWiUHX/Jbxxgn LaWA== X-Gm-Message-State: AJcUukd7aSL02B9m5oUf4EdgpDO2Edye6PHbHdQFsTLT/JmcbQMX9mc+ U1aT1msUxQZ75TAmlN+U4oFhQyKw X-Google-Smtp-Source: ALg8bN4ahhRV7T284+vmejQ1WR98Y1CSW6GMevPlHA2JA09dkbb77DIrdZsUXFtiZzPSbWpxEThRHg== X-Received: by 2002:adf:a4d9:: with SMTP id h25mr12060631wrb.167.1548445190572; Fri, 25 Jan 2019 11:39:50 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:fc07:c732:1a36:65ad? (p200300EA8BF1E200FC07C7321A3665AD.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:fc07:c732:1a36:65ad]) by smtp.googlemail.com with ESMTPSA id c129sm46008583wma.48.2019.01.25.11.39.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 11:39:49 -0800 (PST) Subject: [PATCH net-next 2/2] r8169: enable EEE per default on chip versions from RTL8168g From: Heiner Kallweit To: Realtek linux nic maintainers , David Miller Cc: "netdev@vger.kernel.org" References: <8cce9784-c943-6d52-1e40-a04fbe9b6db6@gmail.com> Message-ID: Date: Fri, 25 Jan 2019 20:39:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <8cce9784-c943-6d52-1e40-a04fbe9b6db6@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Enable EEE per default on chip versions from RTL8168g. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index f46bf1187..9e335d2c7 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -2172,6 +2172,14 @@ static const struct ethtool_ops rtl8169_ethtool_ops = { .set_link_ksettings = phy_ethtool_set_link_ksettings, }; +static void rtl_enable_eee(struct rtl8169_private *tp) +{ + int supported = rtl_get_eee_supp(tp); + + if (supported > 0) + rtl_set_eee_adv(tp, supported); +} + static void rtl8169_get_mac_version(struct rtl8169_private *tp) { /* @@ -3623,12 +3631,14 @@ static void rtl8168g_1_hw_phy_config(struct rtl8169_private *tp) rtl8168g_disable_aldps(tp); rtl8168g_config_eee_phy(tp); + rtl_enable_eee(tp); } static void rtl8168g_2_hw_phy_config(struct rtl8169_private *tp) { rtl_apply_firmware(tp); rtl8168g_config_eee_phy(tp); + rtl_enable_eee(tp); } static void rtl8168h_1_hw_phy_config(struct rtl8169_private *tp) @@ -3735,6 +3745,7 @@ static void rtl8168h_1_hw_phy_config(struct rtl8169_private *tp) rtl8168g_disable_aldps(tp); rtl8168g_config_eee_phy(tp); + rtl_enable_eee(tp); } static void rtl8168h_2_hw_phy_config(struct rtl8169_private *tp) @@ -3804,6 +3815,7 @@ static void rtl8168h_2_hw_phy_config(struct rtl8169_private *tp) rtl8168g_disable_aldps(tp); rtl8168g_config_eee_phy(tp); + rtl_enable_eee(tp); } static void rtl8168ep_1_hw_phy_config(struct rtl8169_private *tp) @@ -3833,6 +3845,7 @@ static void rtl8168ep_1_hw_phy_config(struct rtl8169_private *tp) rtl8168g_disable_aldps(tp); rtl8168g_config_eee_phy(tp); + rtl_enable_eee(tp); } static void rtl8168ep_2_hw_phy_config(struct rtl8169_private *tp) @@ -3911,6 +3924,7 @@ static void rtl8168ep_2_hw_phy_config(struct rtl8169_private *tp) rtl8168g_disable_aldps(tp); rtl8168g_config_eee_phy(tp); + rtl_enable_eee(tp); } static void rtl8102e_hw_phy_config(struct rtl8169_private *tp) -- 2.20.1