From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74ABFC43463 for ; Mon, 21 Sep 2020 11:16:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B6A5207BC for ; Mon, 21 Sep 2020 11:16:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbgIULQP (ORCPT ); Mon, 21 Sep 2020 07:16:15 -0400 Received: from dispatch1-us1.ppe-hosted.com ([148.163.129.52]:60962 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbgIULQP (ORCPT ); Mon, 21 Sep 2020 07:16:15 -0400 X-Greylist: delayed 424 seconds by postgrey-1.27 at vger.kernel.org; Mon, 21 Sep 2020 07:16:14 EDT Received: from dispatch1-us1.ppe-hosted.com (localhost.localdomain [127.0.0.1]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 677082F1B22; Mon, 21 Sep 2020 11:09:10 +0000 (UTC) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.62]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 2462160094; Mon, 21 Sep 2020 11:09:10 +0000 (UTC) Received: from us4-mdac16-19.ut7.mdlocal (unknown [10.7.65.243]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 231E98009B; Mon, 21 Sep 2020 11:09:10 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.198]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id A534A280050; Mon, 21 Sep 2020 11:09:09 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 480D480064; Mon, 21 Sep 2020 11:09:09 +0000 (UTC) Received: from [10.17.20.203] (10.17.20.203) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Sep 2020 12:09:03 +0100 Subject: Re: [PATCH net] sfc: Fix error code in probe To: Dan Carpenter , Solarflare linux maintainers CC: Martin Habets , "David S. Miller" , Jakub Kicinski , , References: <20200918143311.GD909725@mwanda> From: Edward Cree Message-ID: Date: Mon, 21 Sep 2020 12:09:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200918143311.GD909725@mwanda> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [10.17.20.203] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25674.003 X-TM-AS-Result: No-1.659200-8.000000-10 X-TMASE-MatchedRID: lORh06tOiKiVvdyNUeenHvZvT2zYoYOwC/ExpXrHizxWm0JlHAu9AZv8 OBKGKGJryV4nwPo8PJ5bCKebpR3kAmohFAYfTz4engIgpj8eDcC063Wh9WVqgmWCfbzydb0giCF ykZQ+I/rkwjHXXC/4I7I7zVffJqTz9MczSNkeYuFdAFp9PR8A620k9DEV75rzWrRC8SNfq4Ie+1 Y24ck3WtQ17CngTb9OBKmZVgZCVnezGTWRXUlrx+EijnvekEIH X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--1.659200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25674.003 X-MDID: 1600686550-7cbZsTNaApI7 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/09/2020 15:33, Dan Carpenter wrote: > This failure path should return a negative error code but it currently > returns success. > > Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver") > Signed-off-by: Dan Carpenter Acked-by: Edward Cree Thanks for catching this.